Bug 82842

Summary: perf-o-matic should have a way to hide some platforms and tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit WebsiteAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jesus, menard, morrita, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Adds the feature
none
Screenshot of the admin page none

Ryosuke Niwa
Reported 2012-04-01 00:48:48 PDT
DeprecatedQt and Bindings/dom_attributes_id_getter for example should be hidden from the dashboard and the list of platforms and tests on the custom chart page.
Attachments
Adds the feature (21.83 KB, patch)
2012-04-01 01:14 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Screenshot of the admin page (deleted)
2012-04-01 01:14 PDT, Ryosuke Niwa 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-04-01 00:51:06 PDT
I'm not adding an ability to delete things because deleting model objects is very slow on the app engine, and I'd rather not permanently delete objects just yet.
Ryosuke Niwa
Comment 2 2012-04-01 01:14:00 PDT
Created attachment 134989 [details] Adds the feature
Ryosuke Niwa
Comment 3 2012-04-01 01:14:39 PDT
Created attachment 134990 [details] Screenshot of the admin page
Hajime Morrita
Comment 4 2012-04-01 17:39:44 PDT
Comment on attachment 134989 [details] Adds the feature View in context: https://bugs.webkit.org/attachment.cgi?id=134989&action=review > Websites/webkit-perf.appspot.com/admin_handlers.py:101 > + self.response.out.write("Failed to parse the payload: %s" % self.request.body) Would be nice to set some HTTP error code. > Websites/webkit-perf.appspot.com/admin_handlers.py:109 > + self.response.out.write('Not supported') Ditto > Websites/webkit-perf.appspot.com/admin_handlers.py:113 > + self.response.out.write('Could not find the model') Ditto. > Websites/webkit-perf.appspot.com/js/admin.js:1 > +function submitXHR(method, action, payload, callback) { It looks you can just use $.ajax http://api.jquery.com/jQuery.ajax/
Ryosuke Niwa
Comment 5 2012-04-01 17:49:22 PDT
(In reply to comment #4) > (From update of attachment 134989 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134989&action=review > > > Websites/webkit-perf.appspot.com/admin_handlers.py:101 > > + self.response.out.write("Failed to parse the payload: %s" % self.request.body) > > Would be nice to set some HTTP error code. Admin page, like other perf-o-matic pages, check the response text and shows an error dialog when it's not equal to 'OK'. If we're making that change, it should be a separate patch. Also, it likely requires an upstream change if we wanted to be consistent. > > Websites/webkit-perf.appspot.com/js/admin.js:1 > > +function submitXHR(method, action, payload, callback) { > > It looks you can just use $.ajax > http://api.jquery.com/jQuery.ajax/ It doesn't provide a good API to get the http status code out :(
Hajime Morrita
Comment 6 2012-04-01 17:50:52 PDT
Comment on attachment 134989 [details] Adds the feature okay.
WebKit Review Bot
Comment 7 2012-04-01 18:47:00 PDT
Comment on attachment 134989 [details] Adds the feature Clearing flags on attachment: 134989 Committed r112822: <http://trac.webkit.org/changeset/112822>
WebKit Review Bot
Comment 8 2012-04-01 18:47:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.