Bug 82927

Summary: add css parsing of -webkit-flex
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, menard, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82128    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Tony Chang
Reported 2012-04-02 12:36:15 PDT
add css parsing of -webkit-flex
Attachments
Patch (55.08 KB, patch)
2012-04-02 12:37 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (54.86 KB, patch)
2012-04-02 13:30 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (54.68 KB, patch)
2012-04-02 13:48 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-04-02 12:37:45 PDT
Created attachment 135157 [details] Patch
WebKit Review Bot
Comment 2 2012-04-02 12:42:42 PDT
Attachment 135157 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1 Source/WebCore/rendering/style/RenderStyle.h:1259: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexis Menard (darktears)
Comment 3 2012-04-02 12:46:51 PDT
Comment on attachment 135157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135157&action=review > Source/WebCore/css/CSSParser.cpp:1794 > + if (RefPtr<CSSValue> flex = parseFlex(value->function->args.get())) { If you fallback to the end of the switch with validPrimitive and parsedValue it is not good?
Tony Chang
Comment 4 2012-04-02 13:30:09 PDT
Created attachment 135168 [details] Patch
Tony Chang
Comment 5 2012-04-02 13:30:53 PDT
(In reply to comment #3) > (From update of attachment 135157 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135157&action=review > > > Source/WebCore/css/CSSParser.cpp:1794 > > + if (RefPtr<CSSValue> flex = parseFlex(value->function->args.get())) { > > If you fallback to the end of the switch with validPrimitive and parsedValue it is not good? Good idea; done.
Ojan Vafai
Comment 6 2012-04-02 13:32:03 PDT
Comment on attachment 135157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135157&action=review Please address at least the test comments before committing. > Source/WebCore/css/CSSParser.cpp:1799 > + else if (value->unit == CSSParserValue::Function) { > + if (!equalIgnoringCase(value->function->name, "-webkit-flex(") || m_valueList->next()) > + return false; > + > + if (RefPtr<CSSValue> flex = parseFlex(value->function->args.get())) { > + addProperty(propId, flex.release(), important); > + return true; > + } > + return false; > + } Maybe add a FIXME to remove this once we get rid of the flex function? > Source/WebCore/rendering/style/StyleFlexibleBoxData.cpp:37 > + : m_widthPositiveFlex(RenderStyle::initialPositiveFlex()) > + , m_widthNegativeFlex(RenderStyle::initialNegativeFlex()) > + , m_heightPositiveFlex(RenderStyle::initialPositiveFlex()) > + , m_heightNegativeFlex(RenderStyle::initialNegativeFlex()) Add FIXME to kill these member variables? > LayoutTests/css3/flexbox/flex-property-parsing.html:1 > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> <!DOCTYPE html> Whatever template file generated this is outdated. > LayoutTests/css3/flexbox/flex-property-parsing.html:7 > +<p id="description"></p> Don't need this line anymore. > LayoutTests/css3/flexbox/flex-property-parsing.html:11 > +<div id="console"></div> Don't need this line either. > LayoutTests/css3/flexbox/flex-property-parsing.html:12 > +<script src="script-tests/flex-property-parsing.js"></script> Can you inline this? There's no need to have a separate flex-parsing.js file. We should only use that pattern for pure JS test suites we want to be able to run outside of a browser context.
WebKit Review Bot
Comment 7 2012-04-02 13:33:41 PDT
Attachment 135168 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1 Source/WebCore/rendering/style/RenderStyle.h:1259: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tony Chang
Comment 8 2012-04-02 13:48:59 PDT
Created attachment 135174 [details] Patch for landing
Tony Chang
Comment 9 2012-04-02 13:52:18 PDT
I think the cq will fail to land this because of the style warning.
WebKit Review Bot
Comment 10 2012-04-02 17:24:46 PDT
Comment on attachment 135174 [details] Patch for landing Clearing flags on attachment: 135174 Committed r112968: <http://trac.webkit.org/changeset/112968>
WebKit Review Bot
Comment 11 2012-04-02 17:24:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.