Bug 83555

Summary: Add a function to set empty clients to a PageClients
Product: WebKit Reporter: Kent Tamura <tkent>
Component: SVGAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, rakuco, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 81081    
Attachments:
Description Flags
Patch
none
Patch 2
none
Patch 3 abarth: review+

Kent Tamura
Reported 2012-04-10 01:27:46 PDT
Add a function to set empty clients to a PageClients
Attachments
Patch (12.09 KB, patch)
2012-04-10 01:31 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (12.14 KB, patch)
2012-04-10 03:11 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 3 (12.17 KB, patch)
2012-04-10 03:36 PDT, Kent Tamura 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-04-10 01:31:20 PDT
Created attachment 136413 [details] Patch
Kent Tamura
Comment 2 2012-04-10 01:56:05 PDT
Note: The setEmptyClientsTo() function will be used in the patch of Bug 81081.
Build Bot
Comment 3 2012-04-10 02:53:37 PDT
Comment on attachment 136413 [details] Patch Attachment 136413 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12372793
Kent Tamura
Comment 4 2012-04-10 03:11:02 PDT
Created attachment 136417 [details] Patch 2 can fix Windows build?
Build Bot
Comment 5 2012-04-10 03:27:48 PDT
Comment on attachment 136417 [details] Patch 2 Attachment 136417 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12369901
Kent Tamura
Comment 6 2012-04-10 03:36:45 PDT
Created attachment 136419 [details] Patch 3 can fix Windows build? 2
Adam Barth
Comment 7 2012-04-10 12:05:50 PDT
Comment on attachment 136419 [details] Patch 3 View in context: https://bugs.webkit.org/attachment.cgi?id=136419&action=review > Source/WebCore/loader/EmptyClients.h:619 > +void setEmptyClientsTo(Page::PageClients&); setEmptyClientsTo -> fillWithEmptyClients ?
Kent Tamura
Comment 8 2012-04-10 18:49:16 PDT
(In reply to comment #7) > > Source/WebCore/loader/EmptyClients.h:619 > > +void setEmptyClientsTo(Page::PageClients&); > > setEmptyClientsTo -> fillWithEmptyClients ? I'll rename so, and land the patch. Thanks.
Kent Tamura
Comment 9 2012-04-10 19:27:24 PDT
Committed r113811: <http://trac.webkit.org/changeset/113811>
Note You need to log in before you can comment on or make changes to this bug.