Bug 84045

Summary: [GTK] Expose title and alternative text for links in image maps
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cdumez, cfleizach, commit-queue, dmazzoni, gyuyoung.kim, jdiggs, rakuco, zan
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 25531, 98347    
Attachments:
Description Flags
Patch proposal cfleizach: review+

Mario Sanchez Prada
Reported 2012-04-16 09:47:08 PDT
This should allow unskipping accessibility/image-map1.html and accessibility/image-map2.html
Attachments
Patch proposal (8.08 KB, patch)
2013-10-23 09:41 PDT, Mario Sanchez Prada 		cfleizach: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-09-04 05:37:40 PDT
accessibility/image-map1.html is failing since r155022. http://trac.webkit.org/changeset/155022 The diff: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/accessibility/image-map1-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/accessibility/image-map1-actual.txt @@ -4,12 +4,18 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS body.childAtIndex(0).role is 'AXRole: AXLink' -FAIL body.childAtIndex(0).title should be AXTitle: Link1. Was AXTitle: . -PASS body.childAtIndex(1).role is 'AXRole: AXLink' -FAIL body.childAtIndex(1).title should be AXTitle: Link2. Was AXTitle: . -PASS body.childAtIndex(2).role is 'AXRole: AXLink' -FAIL body.childAtIndex(2).title should be AXTitle: Link3. Was AXTitle: . +Link1 role: AXRole: AXLink +Link1 title: AXTitle: +Link1 description: AXDescription: + +Link2 role: AXRole: AXLink +Link2 title: AXTitle: +Link2 description: AXDescription: + +Link3 role: AXRole: AXLink +Link3 title: AXTitle: +Link3 description: AXDescription: + PASS successfullyParsed is true TEST COMPLETE
Zan Dobersek
Comment 2 2013-09-04 05:38:08 PDT
Note that both tests are being run (i.e. are not skipped), and have GTK-specific baselines.
Mario Sanchez Prada
Comment 3 2013-10-23 09:41:46 PDT
Created attachment 214972 [details] Patch proposal This patch mimics what the Mac does and fixes the issue. The situation has slighly changed since this bug was reported, but I checked results now and this patch seems to be the right one. As a plus, it allows us to share the expectations between GTK, EFL and Mac, which is good too.
Mario Sanchez Prada
Comment 4 2013-10-28 02:56:10 PDT
Committed r158104: <http://trac.webkit.org/changeset/158104>
Note You need to log in before you can comment on or make changes to this bug.