Bug 84434

Summary:

[Qt][WK2] Convert touch-point area

Product:

WebKit

Reporter:

Allan Sandfeld Jensen <allan.jensen>

Component:

WebKit2

Assignee:

Allan Sandfeld Jensen <allan.jensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jturcotte, menard, ossy, webkit.review.bot, zoltan

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

79666

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none
Patch for failing test	none

Allan Sandfeld Jensen

Reported 2012-04-20 04:48:41 PDT

In WK1 touch-point area is now converted from QTouchEvent::TouchPoint to PlatformTouchPoint, but it's missing from WK2.

Attachments
Patch (12.66 KB, patch) 2012-04-20 04:53 PDT, Allan Sandfeld Jensen	no flags	Details Formatted Diff Diff
Patch for landing (9.12 KB, patch) 2012-04-23 09:25 PDT, Allan Sandfeld Jensen	no flags	Details Formatted Diff Diff
Patch for landing (12.70 KB, patch) 2012-04-23 09:30 PDT, Allan Sandfeld Jensen	no flags	Details Formatted Diff Diff
Patch for failing test (8.11 KB, patch) 2012-04-24 06:46 PDT, Allan Sandfeld Jensen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Allan Sandfeld Jensen

Comment 1 2012-04-20 04:53:53 PDT

Created attachment 138069 [details] Patch

Kenneth Rohde Christiansen

Comment 2 2012-04-20 09:21:28 PDT

Comment on attachment 138069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138069&action=review > Source/WebKit2/ChangeLog:6 > + [Qt][WK2] Convert touch-point area. > + https://bugs.webkit.org/show_bug.cgi?id=84434 > + > + Reviewed by NOBODY (OOPS!). it would be nicer with more descriptive changelogs explaining why this is a good idea and what it means etc.

Kenneth Rohde Christiansen

Comment 3 2012-04-20 09:21:32 PDT

Allan Sandfeld Jensen

Comment 4 2012-04-21 06:27:31 PDT

(In reply to comment #2) > (From update of attachment 138069 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138069&action=review > > > Source/WebKit2/ChangeLog:6 > > + [Qt][WK2] Convert touch-point area. > > + https://bugs.webkit.org/show_bug.cgi?id=84434 > > + > > + Reviewed by NOBODY (OOPS!). > > it would be nicer with more descriptive changelogs explaining why this is a good idea and what it means etc. Okay. I left it out because it was really just an omission from a previous patch. It means dom touch-events when accessed from javascript does not have radius (and pressure) parameters. Well, at least not if the event comes from WebKit2, from WebKit1 the conversion is already handled.

Kenneth Rohde Christiansen

Comment 5 2012-04-21 09:39:23 PDT

Comment on attachment 138069 [details] Patch Please add a bit more info to the changelog

Allan Sandfeld Jensen

Comment 6 2012-04-23 09:25:52 PDT

Created attachment 138363 [details] Patch for landing

Allan Sandfeld Jensen

Comment 7 2012-04-23 09:27:33 PDT

Comment on attachment 138363 [details] Patch for landing missed new files

Allan Sandfeld Jensen

Comment 8 2012-04-23 09:30:25 PDT

Created attachment 138364 [details] Patch for landing

WebKit Review Bot

Comment 9 2012-04-23 10:37:15 PDT

Comment on attachment 138364 [details] Patch for landing Clearing flags on attachment: 138364 Committed r114917: <http://trac.webkit.org/changeset/114917>

WebKit Review Bot

Comment 10 2012-04-23 10:37:29 PDT

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 11 2012-04-24 01:31:31 PDT

Reopen, because fast/events/touch/basic-single-touch-events.html started to fail after this change. http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r114919%20%281606%29/fast/events/touch/basic-single-touch-events-pretty-diff.html

Csaba Osztrogonác

Comment 12 2012-04-24 01:36:00 PDT

I skipped it to make the bot happier a little bit - http://trac.webkit.org/changeset/115010/trunk/LayoutTests/platform/qt-5.0-wk2/Skipped Please unskip it with the proper fix.

Allan Sandfeld Jensen

Comment 13 2012-04-24 01:39:05 PDT

(In reply to comment #12) > I skipped it to make the bot happier a little bit - http://trac.webkit.org/changeset/115010/trunk/LayoutTests/platform/qt-5.0-wk2/Skipped > > Please unskip it with the proper fix. It looks like the bot is not running with the new DumpRenderTree function.

Csaba Osztrogonác

Comment 14 2012-04-24 03:35:54 PDT

Do you use the latest pinned Qt5 hash?

Allan Sandfeld Jensen

Comment 15 2012-04-24 06:46:10 PDT

Created attachment 138550 [details] Patch for failing test Also adds the new EventSender API to WebKitTestRunner

WebKit Review Bot

Comment 16 2012-04-24 09:28:37 PDT

Comment on attachment 138550 [details] Patch for failing test Clearing flags on attachment: 138550 Committed r115071: <http://trac.webkit.org/changeset/115071>

WebKit Review Bot

Comment 17 2012-04-24 09:28:43 PDT

All reviewed patches have been landed. Closing bug.

Jocelyn Turcotte

Comment 18 2012-05-16 02:43:10 PDT

Committed r117245: <http://trac.webkit.org/changeset/117245>

Note You need to log in before you can comment on or make changes to this bug.