Bug 85725

Summary: Eliminate duplicated code for culled line box in RenderInline
Product: WebKit Reporter: Tien-Ren Chen <trchen>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, hyatt, jchaffraix, mitz, trchen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687, 79150, 84936    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Tien-Ren Chen
Reported 2012-05-05 21:25:09 PDT
Eliminate duplicated code for culled line box in RenderInline
Attachments
Patch (23.27 KB, patch)
2012-05-05 21:34 PDT, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Patch (23.28 KB, patch)
2012-05-10 14:44 PDT, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Patch for landing (22.98 KB, patch)
2012-05-10 14:58 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tien-Ren Chen
Comment 1 2012-05-05 21:34:11 PDT
Created attachment 140417 [details] Patch
Tien-Ren Chen
Comment 2 2012-05-08 14:04:34 PDT
Can someone take a look at this please? I think it is a good refactor to have one single function to generate all the local rects of a RenderInline. There is one concern with this patch is the use of template and generator pattern, neither of them is used in WebKit. I use such seemingly over-complicated construct to make sure the compiled code will be as efficient as it was. If performance is not that much a concern I can make a simpler implementation that returns just a Vector<FloatRect>.
Adam Barth
Comment 3 2012-05-09 16:00:13 PDT
@Eric: Would you be willing to look at this patch?
Eric Seidel (no email)
Comment 4 2012-05-09 16:39:02 PDT
Comment on attachment 140417 [details] Patch Are you around #webkit that we could discuss this?
Tien-Ren Chen
Comment 5 2012-05-09 17:02:07 PDT
(In reply to comment #4) > (From update of attachment 140417 [details]) > Are you around #webkit that we could discuss this? Sorry I'll need to go on an errand right now. I'll reach you tomorrow morning if it is convenient to you. Thanks!
Eric Seidel (no email)
Comment 6 2012-05-10 14:05:05 PDT
Comment on attachment 140417 [details] Patch This is fantastic. Thank you!
WebKit Review Bot
Comment 7 2012-05-10 14:15:00 PDT
Comment on attachment 140417 [details] Patch Rejecting attachment 140417 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12671094
Tien-Ren Chen
Comment 8 2012-05-10 14:44:44 PDT
Created attachment 141266 [details] Patch
Tien-Ren Chen
Comment 9 2012-05-10 14:45:31 PDT
Nothing changed. Just rebase and add back "Reviewed by" line.
Adam Barth
Comment 10 2012-05-10 14:58:35 PDT
Created attachment 141271 [details] Patch for landing
WebKit Review Bot
Comment 11 2012-05-10 19:07:22 PDT
Comment on attachment 141271 [details] Patch for landing Clearing flags on attachment: 141271 Committed r116718: <http://trac.webkit.org/changeset/116718>
WebKit Review Bot
Comment 12 2012-05-10 19:07:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.