Bug 85764

Summary: [Chromium] Move createMessagePortChannel to Platform.h
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 86559    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-05-06 19:36:09 PDT
[Chromium] Move createMessagePortChannel to Platform.h
Attachments
Patch (4.98 KB, patch)
2012-05-06 19:36 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (16.12 KB, patch)
2012-05-15 14:59 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (20.35 KB, patch)
2012-06-06 06:57 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (18.63 KB, patch)
2012-06-06 12:02 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-05-06 19:36:45 PDT
Created attachment 140456 [details] Patch
WebKit Review Bot
Comment 2 2012-05-06 19:39:50 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-05-06 20:38:24 PDT
Comment on attachment 140456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140456&action=review > Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:-60 > -class WebMessagePortChannel; // FIXME: Does this belong in platform? We'll also want to move WebMessagePortChannel and WebMessagePortChannelClient int Source/Platform/chromium/public as well. They look like they'll move cleanly, so the answer to this comment seems to be "yes". > Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:46 > namespace WebCore { Once you move WebMessagePortChannel into Source/Platform/chromium/public, you can move all this code into WebCore/platform where it belongs. :)
Mark Pilgrim (Google)
Comment 4 2012-05-15 14:59:57 PDT
Created attachment 142067 [details] Patch
Mark Pilgrim (Google)
Comment 5 2012-05-15 15:00:31 PDT
Comment on attachment 142067 [details] Patch Now moves WebMessagePortChannel and WebMessagePortChannelClient.
Adam Barth
Comment 6 2012-05-15 15:07:03 PDT
Comment on attachment 142067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142067&action=review > Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:46 > namespace WebCore { This patch is great. Thanks! A good followup patch might be to try to move this code in the WebCore namespace into Source/WebCore/platform/chromium.
WebKit Review Bot
Comment 7 2012-05-15 19:29:25 PDT
Comment on attachment 142067 [details] Patch Clearing flags on attachment: 142067 Committed r117204: <http://trac.webkit.org/changeset/117204>
WebKit Review Bot
Comment 8 2012-05-15 19:29:29 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2012-05-15 20:12:37 PDT
Re-opened since this is blocked by 86559
Mark Pilgrim (Google)
Comment 10 2012-06-06 06:57:40 PDT
Created attachment 146012 [details] Patch
Adam Barth
Comment 11 2012-06-06 09:52:44 PDT
Comment on attachment 146012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146012&action=review > Source/WebKit/chromium/public/WebFrame.h:42 > +#include <public/WebMessagePortChannel.h> The #includes in Source/WebKit/chromium/public should use forwarding headers, like WebURL.h above. > Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:123 > PlatformMessagePortChannel::PlatformMessagePortChannel() This whole class should probably move into WebCore.
Adam Barth
Comment 12 2012-06-06 09:53:03 PDT
(Feel free to move PlatformMessagePortChannel in a followup patch.)
Mark Pilgrim (Google)
Comment 13 2012-06-06 12:02:28 PDT
Created attachment 146080 [details] Patch
Mark Pilgrim (Google)
Comment 14 2012-06-06 12:03:16 PDT
Comment on attachment 146080 [details] Patch reverted headers in chromium/public/
WebKit Review Bot
Comment 15 2012-06-06 19:40:58 PDT
Comment on attachment 146080 [details] Patch Clearing flags on attachment: 146080 Committed r119666: <http://trac.webkit.org/changeset/119666>
WebKit Review Bot
Comment 16 2012-06-06 19:41:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.