Bug 86433

Summary: script-src-redirect.html is flaky.
Product: WebKit Reporter: Mike West <mkwst>
Component: WebCore Misc.Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, rakuco, tkent, webkit.review.bot, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77556, 86643    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mike West
Reported 2012-05-14 21:23:43 PDT
From https://bugs.webkit.org/show_bug.cgi?id=86323: (In reply to comment #22) > (From update of attachment 141783 [details] [details]) > Clearing flags on attachment: 141783 > > Committed r117006: <http://trac.webkit.org/changeset/117006> After this, script-src-redirect.html has been really flaky. I wonder if we should roll it out. --- Looks like `script-src-redirect.html` is another iframe ordering test. I'll rewrite it to use the same methodology as `source-list-parsing.html`.
Attachments
Patch (4.50 KB, patch)
2012-05-15 08:06 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Patch (12.74 KB, patch)
2012-05-18 02:11 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Patch (16.58 KB, patch)
2012-05-18 06:01 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-05-15 08:06:15 PDT
Created attachment 141971 [details] Patch
Mike West
Comment 2 2012-05-15 08:07:34 PDT
Can you take a look at this, Adam? :)
WebKit Review Bot
Comment 3 2012-05-15 12:51:01 PDT
Comment on attachment 141971 [details] Patch Clearing flags on attachment: 141971 Committed r117123: <http://trac.webkit.org/changeset/117123>
WebKit Review Bot
Comment 4 2012-05-15 12:51:06 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 7 2012-05-15 18:49:49 PDT
Thanks really strange. Maybe it's some kind of strange race where we're loading about:blank but it's using the URL of the parent document for the CSP check somehow? Another possibility is that we're using "" as the src somehow and that's getting resolve to match the URL of the parent document.
Zoltan Arvai
Comment 8 2012-05-16 02:34:37 PDT
http/tests/security/contentSecurityPolicy/script-src-redirect.html skipped on Qt in trac.webkit.org/changeset/117243 . Please unskip the test when it works again.
Mike West
Comment 9 2012-05-18 01:58:09 PDT
Arg. It's not a strange race. It's a stupid typo. :/ I'll have a patch for review in a few minutes.
Mike West
Comment 10 2012-05-18 02:11:25 PDT
Created attachment 142669 [details] Patch
jochen
Comment 11 2012-05-18 02:17:56 PDT
Comment on attachment 142669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142669&action=review > LayoutTests/http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:2 > + layoutTestController.waitUntilDone(); 4 spaces indenting > LayoutTests/http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:11 > + var baseURL = 'http://127.0.0.1:8000/security/contentSecurityPolicy/'; please either use ' or " > LayoutTests/platform/chromium/test_expectations.txt:-3724 > -BUGWK86433 : http/tests/security/contentSecurityPolicy/script-src-redirect.html = TEXT PASS why not unskip it for the other platforms as well?
Mike West
Comment 12 2012-05-18 06:01:24 PDT
Created attachment 142698 [details] Patch
Mike West
Comment 13 2012-05-18 06:02:41 PDT
Thanks, Jochen. I've addressed your comments.
WebKit Review Bot
Comment 14 2012-05-18 06:46:02 PDT
Comment on attachment 142698 [details] Patch Clearing flags on attachment: 142698 Committed r117583: <http://trac.webkit.org/changeset/117583>
WebKit Review Bot
Comment 15 2012-05-18 06:46:23 PDT
All reviewed patches have been landed. Closing bug.
Mike West
Comment 16 2012-05-18 08:02:07 PDT
It looks like http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=script-src-redirect.html is greening up nicely.
Note You need to log in before you can comment on or make changes to this bug.