Bug 87101

Summary: Rename FrameLoaderClient::shadowDOMAllowed() to allowShadowDOM()
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: PlatformAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 87063    
Bug Blocks: 86984    
Attachments:
Description Flags
Patch
none
Patch for landing none

Hajime Morrita
Reported 2012-05-22 01:41:19 PDT
That is poorly named and should follow its families.
Attachments
Patch (4.97 KB, patch)
2012-05-28 01:32 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.03 KB, patch)
2012-05-28 16:58 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-05-28 01:32:20 PDT
Created attachment 144301 [details] Patch
Kentaro Hara
Comment 2 2012-05-28 01:34:32 PDT
Comment on attachment 144301 [details] Patch OK
Darin Adler
Comment 3 2012-05-28 02:52:40 PDT
Comment on attachment 144301 [details] Patch This naming in the client does not seem good. We want boolean functions to finish phrases like this "client <xxx>". The phrases "client allow image" and "client allow shadow DOM" are not grammatical. Adding the letter "s" might be sufficient to make these follow the guideline: "allows shadow DOM". When did these names get into WebKit? Did I just overlook it?
WebKit Review Bot
Comment 4 2012-05-28 03:09:00 PDT
Comment on attachment 144301 [details] Patch Rejecting attachment 144301 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: nabledFeatures.cpp patching file Source/WebCore/loader/FrameLoaderClient.h patching file Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp patching file Source/WebKit/chromium/src/FrameLoaderClientImpl.h Hunk #1 FAILED at 199. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/FrameLoaderClientImpl.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12849124
Hajime Morrita
Comment 5 2012-05-28 16:58:19 PDT
Created attachment 144409 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-05-28 18:50:23 PDT
Comment on attachment 144409 [details] Patch for landing Clearing flags on attachment: 144409 Committed r118714: <http://trac.webkit.org/changeset/118714>
WebKit Review Bot
Comment 7 2012-05-28 18:50:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.