Bug 87145

Summary: REGRESSION (r117815) fast/css/zoom-in-length-round-trip.html fails on Mac bots
Product: WebKit Reporter: Brady Eidson <beidson>
Component: CSSAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, leviw, szledan
Priority: P2 Keywords: LayoutTestFailure, Regression
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch none

Brady Eidson
Reported 2012-05-22 10:48:35 PDT
REGRESSION (r117815) fast/css/zoom-in-length-round-trip.html fails on Mac bots Link to change: http://trac.webkit.org/changeset/117815 Link to example of failure: http://build.webkit.org/results/Lion%20Release%20(Tests)/r117988%20(8548)/results.html 117815 purported to be only about enabling a feature on Chromium, so it seems odd it could have caused this. But it never failed up to and including 117813, then has been failing started in 117815. 117814 cannot possibly have affected Mac as it only touched a Chromium.cpp file - (http://trac.webkit.org/changeset/117814) - so 117815 must be it.
Attachments
Patch (2.34 KB, patch)
2012-05-22 11:42 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-05-22 10:53:02 PDT
Skipped in http://trac.webkit.org/changeset/118003 Please unskip after you have resolved the regression.
Eric Seidel (no email)
Comment 2 2012-05-22 11:24:39 PDT
It's possible, but it would have come from an earlier change in teh subpixel change I think.
Brady Eidson
Comment 3 2012-05-22 11:28:55 PDT
(In reply to comment #2) > It's possible, but it would have come from an earlier change in teh subpixel change I think. I'm having a hard time grok'ing this sentence. All I know is that from 117813 back the test was fine.
Levi Weintraub
Comment 4 2012-05-22 11:30:40 PDT
(In reply to comment #3) > (In reply to comment #2) > > It's possible, but it would have come from an earlier change in teh subpixel change I think. > > I'm having a hard time grok'ing this sentence. > > All I know is that from 117813 back the test was fine. The numbers being returned are correct, it looks like a test issue.
Emil A Eklund
Comment 5 2012-05-22 11:42:33 PDT
Created attachment 143337 [details] Patch
Eric Seidel (no email)
Comment 6 2012-05-22 11:46:22 PDT
Comment on attachment 143337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review > LayoutTests/fast/css/zoom-in-length-round-trip.html:33 > + if (hasSubpixelSupport && (target.offsetWidth == 1 || target.offsetWidth == 2) && (target.offsetHeight == 10 || target.offsetHeight == 11)) I don'dt quite understnad thsi complicated check.
Emil A Eklund
Comment 7 2012-05-22 11:48:30 PDT
(In reply to comment #6) > (From update of attachment 143337 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review > > > LayoutTests/fast/css/zoom-in-length-round-trip.html:33 > > + if (hasSubpixelSupport && (target.offsetWidth == 1 || target.offsetWidth == 2) && (target.offsetHeight == 10 || target.offsetHeight == 11)) > > I don'dt quite understnad thsi complicated check. That's why I added the comment...
Levi Weintraub
Comment 8 2012-05-22 11:49:04 PDT
Comment on attachment 143337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review Please also unskip this test on Mac before landing. > LayoutTests/fast/css/zoom-in-length-round-trip.html:33 > + if (hasSubpixelSupport && (target.offsetWidth == 1 || target.offsetWidth == 2) && (target.offsetHeight == 10 || target.offsetHeight == 11)) This is ugly to have to do, but okay.
Brady Eidson
Comment 9 2012-05-22 11:55:42 PDT
Even though Levi r+'ed, please unskip the test as well.
Emil A Eklund
Comment 10 2012-05-22 11:57:19 PDT
(In reply to comment #9) > Even though Levi r+'ed, please unskip the test as well. Will do!
Levi Weintraub
Comment 11 2012-05-22 11:57:25 PDT
(In reply to comment #8) > (From update of attachment 143337 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review > > Please also unskip this test on Mac before landing. ^^^ :)
Emil A Eklund
Comment 12 2012-05-22 11:59:49 PDT
Committed r118013: <http://trac.webkit.org/changeset/118013>
Levi Weintraub
Comment 13 2012-05-22 12:15:12 PDT
*** Bug 87099 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.