Bug 87646

Summary: Fix ENABLE_IFRAME_SEAMLESS to actually fully disable <iframe seamless>
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aestes, bdakin, jberlin, lforschler, sam, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 45950    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2012-05-28 03:15:51 PDT
Fix ENABLE_IFRAME_SEAMLESS to actually fully disable <iframe seamless>
Attachments
Patch (2.65 KB, patch)
2012-05-28 03:18 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-05-28 03:18:46 PDT
Created attachment 144320 [details] Patch
Eric Seidel (no email)
Comment 2 2012-05-28 03:51:21 PDT
Apple may want to pull this into their release branches, since I believe they've disabled seamless there.
Radar WebKit Bug Importer
Comment 3 2012-05-29 13:23:19 PDT
<rdar://problem/11550608>
WebKit Review Bot
Comment 4 2012-05-29 19:28:33 PDT
Comment on attachment 144320 [details] Patch Clearing flags on attachment: 144320 Committed r118883: <http://trac.webkit.org/changeset/118883>
WebKit Review Bot
Comment 5 2012-05-29 19:28:38 PDT
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 6 2012-05-30 13:13:23 PDT
What is the symptom if this bug is not incorporated? Is there a user visible effect?
Adam Barth
Comment 7 2012-05-30 13:27:29 PDT
> What is the symptom if this bug is not incorporated? Is there a user visible effect? The symptom is that an iframe with the seamless attribute would exhibit some of the seamless behaviors (e.g., style inheritance), but not all of them (e.g., redirected navigation). The effect should only be visible in content that attempts to use the seamless attribute.
Sam Weinig
Comment 8 2012-05-30 14:41:12 PDT
(In reply to comment #7) > > What is the symptom if this bug is not incorporated? Is there a user visible effect? > > The symptom is that an iframe with the seamless attribute would exhibit some of the seamless behaviors (e.g., style inheritance), but not all of them (e.g., redirected navigation). The effect should only be visible in content that attempts to use the seamless attribute. Thanks Adam.
Note You need to log in before you can comment on or make changes to this bug.