Bug 88210

Summary: Expose layoutTestController as testRunner
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, jesus, jonlee, kpiascik, mitz, mjs, mxie, ojan, rakuco, rwlbuis, tkent, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 88755, 88757, 88761, 88766, 88769, 88955, 88959, 88969, 89176, 89181, 89182, 89184, 89262, 89263, 89422, 89431, 89438, 89445, 89462, 89654, 89662, 89741, 89744, 91315, 92898, 92944, 92947, 93172, 93173, 93176, 93177, 93184, 93758, 93942    
Attachments:
Description Flags
Patch
none
Added the forgotten WebKitTestRunner change none

Ryosuke Niwa
Reported 2012-06-03 21:03:31 PDT
Expose layoutTestController as testRunner
Attachments
Patch (5.78 KB, patch)
2012-06-03 21:08 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Added the forgotten WebKitTestRunner change (6.70 KB, patch)
2012-06-04 00:44 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-06-03 21:08:42 PDT
Created attachment 145512 [details] Patch
Darin Adler
Comment 2 2012-06-04 00:12:46 PDT
Comment on attachment 145512 [details] Patch Looks good for DumpRenderTree and TestShell, but to handle WebKitTestRunner, we also need a change to LayoutTestController::makeWindowObject in Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp. Since this adds a test, we’ll start seeing failures if you don’t add that, so review-.
Ryosuke Niwa
Comment 3 2012-06-04 00:43:43 PDT
(In reply to comment #2) > (From update of attachment 145512 [details]) > Looks good for DumpRenderTree and TestShell, but to handle WebKitTestRunner, we also need a change to LayoutTestController::makeWindowObject in Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp. Since this adds a test, we’ll start seeing failures if you don’t add that, so review-. Oops, I had that change in my mind and totally forgot about it. Uploading a new patch now.
Ryosuke Niwa
Comment 4 2012-06-04 00:44:29 PDT
Created attachment 145529 [details] Added the forgotten WebKitTestRunner change
Ryosuke Niwa
Comment 5 2012-06-04 16:09:47 PDT
Ping reviewers.
Ryosuke Niwa
Comment 6 2012-06-10 13:48:13 PDT
Could someone review the patch?
Ryosuke Niwa
Comment 7 2012-06-10 14:28:11 PDT
Thanks! I'll land this, and start converting tests.
WebKit Review Bot
Comment 8 2012-06-10 14:36:47 PDT
Comment on attachment 145529 [details] Added the forgotten WebKitTestRunner change Clearing flags on attachment: 145529 Committed r119946: <http://trac.webkit.org/changeset/119946>
WebKit Review Bot
Comment 9 2012-06-10 14:36:52 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 10 2012-06-10 19:04:04 PDT
Why doesn't this property get dumped and so show up in “all the properties of the window object” tests?
Ryosuke Niwa
Comment 11 2012-06-10 20:56:32 PDT
(In reply to comment #10) > Why doesn't this property get dumped and so show up in “all the properties of the window object” tests? Which test are you talking about? I thought we got rid of those dump-all-properties tests?
Note You need to log in before you can comment on or make changes to this bug.