Bug 89025

Summary: [chromium] Upstream LayerRendererChromium::drawHighlightQuads from Android port
Product: WebKit Reporter: Iain Merrick <husky>
Component: New BugsAssignee: Iain Merrick <husky>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: aelias, cc-bugs, danakj, husky, jamesr, klobag, peter, trchen, webkit.review.bot, wjmaclean
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch jamesr: review-

Iain Merrick
Reported 2012-06-13 11:29:39 PDT
[chromium] Upstream LayerRendererChromium::drawHighlightQuads from Android port
Attachments
Patch (16.80 KB, patch)
2012-06-13 11:31 PDT, Iain Merrick 		jamesr: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Iain Merrick
Comment 1 2012-06-13 11:31:24 PDT
Created attachment 147373 [details] Patch
Iain Merrick
Comment 2 2012-06-13 11:33:11 PDT
This is the code currently used by the Android port.
Dana Jansens
Comment 3 2012-06-13 11:50:45 PDT
Is the code at all related/similar to link highlight, or could/should it be?
W. James MacLean
Comment 4 2012-06-13 12:19:00 PDT
This looks very related to work already underway at https://bugs.webkit.org/show_bug.cgi?id=84487 I don't think we want two different mechanisms, and if I recall earlier discussions with Nat & James R, there was a desire to not hardwire highlight drawing directly into the compositor. Is there anything we can do in the existing work to accommodate what you're trying to do?
James Robinson
Comment 5 2012-06-13 13:30:08 PDT
Comment on attachment 147373 [details] Patch I don't think it makes sense to build this directly into the compositor - instead, the caller should construct an appropriate layer and set the right bits on it (assuming that this is initiated from the main thread, which appears to be the case).
Iain Merrick
Comment 6 2012-06-13 13:54:33 PDT
This wasn't written by me originally, I'm just unforking code that has been shipped already. I'll take a look at 84487.
Iain Merrick
Comment 7 2012-06-14 10:07:20 PDT
*** This bug has been marked as a duplicate of bug 84487 ***
Alexandre Elias
Comment 8 2012-06-14 15:28:38 PDT
I'll delete this code from the Android branch as there's no plan to ship it again.
Note You need to log in before you can comment on or make changes to this bug.