Bug 89957

Summary: [CSS Shapes] Enable CSS Shapes on Windows
Product: WebKit Reporter: Mihai Balan <mibalan>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: betravis, cmarcelo, commit-queue, donggwan.kim, dstockwell, esprehn+autocc, giles_joplin, glenn, gyuyoung.kim, macpherson, menard, mibalan, ojan.autocc, roger_fong, syoichi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89256    
Attachments:
Description Flags
Defining ENABLE_CSS_EXCLUSIONS
none
Modifying CSSPropertyNames.in
none
Updating patch
none
Patch enabling Shapes, Shape Tests
none
Updated patch
buildbot: commit-queue-
Ensuring CSS properties are regenerated
none
Enabling Tests in TestExpectations none

Mihai Balan
Reported 2012-06-26 01:22:47 PDT
Currently both CSS regions and exclusions are behind feature defines on Mac and Windows. Mac has them enabled. Trying to enable both regions and exclusions on Windows leads to strange link errors and crashes in DRT (see previous patches and comments for #88645). As such, enabling exclusions (once these land on trunk) was extracted in this bug. Things to look out for: * make sure patch properly builds incrementally (you might have to touch CSSPropertyNames.in) * make sure exclusions work in Safari/WebKit on Windows * make sure DRT does not crash
Attachments
Defining ENABLE_CSS_EXCLUSIONS (1.80 KB, patch)
2012-08-27 11:26 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Modifying CSSPropertyNames.in (3.05 KB, patch)
2012-08-27 12:24 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Updating patch (3.08 KB, patch)
2012-09-13 15:45 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Patch enabling Shapes, Shape Tests (8.57 KB, patch)
2013-11-18 17:05 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Updated patch (2.33 KB, patch)
2013-12-03 15:53 PST, Bear Travis 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Ensuring CSS properties are regenerated (8.33 KB, patch)
2013-12-03 17:37 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Enabling Tests in TestExpectations (4.67 KB, patch)
2013-12-04 10:54 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2012-06-26 10:57:24 PDT
Linking to the master exclusions bug (bug 89256)
Bear Travis
Comment 2 2012-08-27 11:26:22 PDT
Created attachment 160754 [details] Defining ENABLE_CSS_EXCLUSIONS
Build Bot
Comment 3 2012-08-27 12:09:10 PDT
Comment on attachment 160754 [details] Defining ENABLE_CSS_EXCLUSIONS Attachment 160754 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13612326
Bear Travis
Comment 4 2012-08-27 12:24:28 PDT
Created attachment 160775 [details] Modifying CSSPropertyNames.in Touching CSSPropertyNames.in to ensure it is properly rebuilt
Bear Travis
Comment 5 2012-09-13 15:45:05 PDT
Created attachment 163987 [details] Updating patch
Bear Travis
Comment 6 2013-11-08 17:27:58 PST
Modifying this bug to reflect the remaining work. Most of the infrastructure was added in bug 118810, but had to be disabled in bug 121879 due to runtime crashes in DRT. The cause of the underlying failure was fixed in bug 121883. Trying to do a bit of history cleanup as well.
Bear Travis
Comment 7 2013-11-08 17:29:33 PST
*** Bug 118810 has been marked as a duplicate of this bug. ***
Bear Travis
Comment 8 2013-11-18 17:05:24 PST
Created attachment 217254 [details] Patch enabling Shapes, Shape Tests
Bear Travis
Comment 9 2013-12-03 15:53:13 PST
Created attachment 218358 [details] Updated patch
Build Bot
Comment 10 2013-12-03 16:54:22 PST
Comment on attachment 218358 [details] Updated patch Attachment 218358 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/42978063
Bear Travis
Comment 11 2013-12-03 17:37:54 PST
Created attachment 218366 [details] Ensuring CSS properties are regenerated
Bear Travis
Comment 12 2013-12-04 10:54:27 PST
Created attachment 218417 [details] Enabling Tests in TestExpectations
Brent Fulgham
Comment 13 2013-12-05 15:14:02 PST
Comment on attachment 218417 [details] Enabling Tests in TestExpectations Looks good. r=me!
WebKit Commit Bot
Comment 14 2013-12-05 15:45:13 PST
Comment on attachment 218417 [details] Enabling Tests in TestExpectations Clearing flags on attachment: 218417 Committed r160200: <http://trac.webkit.org/changeset/160200>
WebKit Commit Bot
Comment 15 2013-12-05 15:45:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.