Bug 90566

Summary: [WK2][EFL] Ewk_View needs to report load status changes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, ryuan.choi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838, 90601    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2012-07-04 09:39:50 PDT
The Ewk_View does not currently report: - Load finished - Provisional load started - Provisional load redirect - Provisional load failed We need the emit signals to notify the client of each load status change.
Attachments
Patch (8.09 KB, patch)
2012-07-04 09:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.32 KB, patch)
2012-07-05 02:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-07-04 09:44:35 PDT
Created attachment 150818 [details] Patch
Chris Dumez
Comment 2 2012-07-05 02:36:20 PDT
Created attachment 150905 [details] Patch Rebase on master.
Kenneth Rohde Christiansen
Comment 3 2012-07-05 21:25:18 PDT
Comment on attachment 150905 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150905&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.h:37 > * - "load,error", const Ewk_Web_Error*: reports main frame load failed. > + * - "load,finished", void: reports load finished. > * - "load,progress", double*: load progress has changed (value from 0.0 to 1.0). > + * - "load,provisional,failed", const Ewk_Web_Error*: view provisional load failed. > + * - "load,provisional,redirect", void: view received redirect for provisional load. > + * - "load,provisional,started", void: view started provisional load. > * - "resource,request,new", const Ewk_Web_Resource_Request*: a resource request was initiated. Why do you need to mark that it is provisional? and if you get load,provisional,failed will that then be followed by load,failed?
Chris Dumez
Comment 4 2012-07-05 22:48:52 PDT
(In reply to comment #3) > (From update of attachment 150905 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150905&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_view.h:37 > > * - "load,error", const Ewk_Web_Error*: reports main frame load failed. > > + * - "load,finished", void: reports load finished. > > * - "load,progress", double*: load progress has changed (value from 0.0 to 1.0). > > + * - "load,provisional,failed", const Ewk_Web_Error*: view provisional load failed. > > + * - "load,provisional,redirect", void: view received redirect for provisional load. > > + * - "load,provisional,started", void: view started provisional load. > > * - "resource,request,new", const Ewk_Web_Resource_Request*: a resource request was initiated. > > Why do you need to mark that it is provisional? and if you get load,provisional,failed will that then be followed by load,failed? Actually, in WebKit1-EFL, we were emitting both signals "load,provisional,failed" and then "load,error" if the provisional load failed. Should we do the same thing for WebKit2-EFL? I know that Qt uses a single signal for those 2 events but this prevents the client from making the distinction if it wants to. For example, in DRT, we had to make the distinction to print the proper output. I checked GTK port as well and while they use a single signal, they have an additional "provisional" / "committed" parameter so that they can be distinguished. As you know, adding a new parameter to an EFL signal is not very convenient or nice, and I would rather use separate signals.
Chris Dumez
Comment 5 2012-07-05 23:06:41 PDT
Ok, so no "load,error" signal after the "load,provisional,failed" then?
WebKit Review Bot
Comment 6 2012-07-05 23:08:10 PDT
Comment on attachment 150905 [details] Patch Clearing flags on attachment: 150905 Committed r121944: <http://trac.webkit.org/changeset/121944>
WebKit Review Bot
Comment 7 2012-07-05 23:08:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.