Bug 9127

Summary: Invoke capturing event listeners when AT_TARGET
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: DOMAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: annevk, kjb525, mjs
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 7788    
Attachments:
Description Flags
Patch
andersca: review-
Better approach ggaren: review+

Anders Carlsson
Reported 2006-05-26 11:33:23 PDT
This is contrary to the DOM 2 spec which says that "A capturing EventListener will not be triggered by events dispatched directly to the EventTarget upon which it is registered." However, Mozilla invokes capturing event listeners when AT_TARGET and live.com (at least) depends on that so we should do it too
Attachments
Patch (4.81 KB, patch)
2006-05-26 11:46 PDT, Anders Carlsson 		andersca: review-
DetailsFormatted DiffDiff
Better approach (4.79 KB, patch)
2006-05-26 12:00 PDT, Anders Carlsson 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2006-05-26 11:42:54 PDT
We used to work this way actually, so this is actually a regression from Safari 1.2. I added code back in 1.2 to make sure we did capturing, then a capture at target, then a bubble at target, then bubbling. At some point the capture at the target must have been removed.
Anders Carlsson
Comment 2 2006-05-26 11:46:14 PDT
Created attachment 8555 [details] Patch
Anders Carlsson
Comment 3 2006-05-26 11:51:09 PDT
Comment on attachment 8555 [details] Patch I'll dig up the way hyatt implemented it and use that
Anders Carlsson
Comment 4 2006-05-26 12:00:21 PDT
Created attachment 8557 [details] Better approach
Geoffrey Garen
Comment 5 2006-05-26 13:09:12 PDT
Comment on attachment 8557 [details] Better approach I'm marking this r+ after talking with Anders and Maciej. We want to emulate the Firefox to support live.com. The Firefox bugzilla about this is: https://bugzilla.mozilla.org/show_bug.cgi?id=235441.
Anne van Kesteren
Comment 6 2006-05-27 14:49:50 PDT
Maciej, weren't you guys planning to not do this? This seems wrong.
Darin Adler
Comment 7 2006-06-04 10:07:38 PDT
*** Bug 7205 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.