Bug 91373

Summary: Layout Test pointer-lock/locked-element-removed-from-dom.html is flaky on chromium win
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Tools / TestsAssignee: Vincent Scheib <scheib>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, scheib, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77029    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Vsevolod Vlasov
Reported 2012-07-16 04:00:20 PDT
The following layout test is flaky on chromium win pointer-lock/locked-element-removed-from-dom.html Probable cause: http://trac.webkit.org/changeset/122626/ flakiness dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=pointer-lock%2Flocked-element-removed-from-dom.html Diff: --- e:\b\build\slave\Webkit_Win__dbg__2_\build\layout-test-results\pointer-lock/locked-element-removed-from-dom-expected.txt +++ e:\b\build\slave\Webkit_Win__dbg__2_\build\layout-test-results\pointer-lock/locked-element-removed-from-dom-actual.txt @@ -13,7 +13,6 @@ PASS document.webkitPointerLockElement is null PASS targetDiv1.parentElement.parentElement is null PASS onwebkitpointerlockerror received after: Remove targetDiv1's parent from iframe & immediately lock target2. (main document handler) -PASS onwebkitpointerlockchange received after: Remove targetDiv1's parent from iframe & immediately lock target2. (iframe handler) PASS successfullyParsed is true TEST COMPLETE
Attachments
Patch (2.79 KB, patch)
2012-07-16 12:35 PDT, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch (3.77 KB, patch)
2012-07-16 12:40 PDT, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.77 KB, patch)
2012-07-16 12:47 PDT, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.77 KB, patch)
2012-07-16 12:48 PDT, Vincent Scheib 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-07-16 04:04:24 PDT
http://trac.webkit.org/changeset/122711
Vincent Scheib
Comment 2 2012-07-16 12:35:12 PDT
Created attachment 152588 [details] Patch
Adrienne Walker
Comment 3 2012-07-16 12:39:21 PDT
Comment on attachment 152588 [details] Patch R=me. Can you re-enable this test when you're landing this?
Vincent Scheib
Comment 4 2012-07-16 12:40:50 PDT
Created attachment 152589 [details] Patch
WebKit Review Bot
Comment 5 2012-07-16 12:45:08 PDT
Comment on attachment 152589 [details] Patch Rejecting attachment 152589 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13264047
Vincent Scheib
Comment 6 2012-07-16 12:47:20 PDT
Created attachment 152590 [details] Patch for landing
Vincent Scheib
Comment 7 2012-07-16 12:48:32 PDT
Created attachment 152591 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-07-16 13:48:54 PDT
Comment on attachment 152591 [details] Patch for landing Clearing flags on attachment: 152591 Committed r122758: <http://trac.webkit.org/changeset/122758>
WebKit Review Bot
Comment 9 2012-07-16 13:48:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.