Bug 91732

Summary: Web Inspector: Drop "Loading..." message from FileContentView
Product: WebKit Reporter: Taiju Tsuiki <tzik>
Component: Web Inspector (Deprecated)Assignee: Taiju Tsuiki <tzik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 68203    
Attachments:
Description Flags
Patch
none
Patch none

Taiju Tsuiki
Reported 2012-07-19 04:35:05 PDT
It seems better to show empty view while loading file.
Attachments
Patch (1.53 KB, patch)
2012-07-19 04:36 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2012-08-13 22:19 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Taiju Tsuiki
Comment 1 2012-07-19 04:36:17 PDT
Created attachment 153227 [details] Patch
Vsevolod Vlasov
Comment 2 2012-07-20 02:53:51 PDT
Comment on attachment 153227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153227&action=review > Source/WebCore/inspector/front-end/FileContentView.js:50 > + this._innerView = new WebInspector.EmptyView(WebInspector.UIString("")); this._innerView = new WebInspector.EmptyView("");
Taiju Tsuiki
Comment 3 2012-08-13 22:19:03 PDT
Created attachment 158213 [details] Patch
Taiju Tsuiki
Comment 4 2012-08-13 22:26:58 PDT
Comment on attachment 153227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153227&action=review >> Source/WebCore/inspector/front-end/FileContentView.js:50 >> + this._innerView = new WebInspector.EmptyView(WebInspector.UIString("")); > > this._innerView = new WebInspector.EmptyView(""); Done I forgot to handle this...
WebKit Review Bot
Comment 5 2012-08-14 02:04:45 PDT
Comment on attachment 158213 [details] Patch Clearing flags on attachment: 158213 Committed r125527: <http://trac.webkit.org/changeset/125527>
WebKit Review Bot
Comment 6 2012-08-14 02:04:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.