Bug 91831

Summary: Web Inspector: Add deleteEntry command and deletionCompleted event to FileSystemAgent.
Product: WebKit Reporter: Taiju Tsuiki <tzik>
Component: Web Inspector (Deprecated)Assignee: Taiju Tsuiki <tzik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, peter+ews, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 91861, 93933    
Bug Blocks: 68203, 91709, 93940    
Attachments:
Description Flags
Patch
none
Patch none

Taiju Tsuiki
Reported 2012-07-20 01:16:13 PDT
Inspector should allow user to delete files and directories on FileSystem.
Attachments
Patch (12.81 KB, patch)
2012-08-14 00:36 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (16.50 KB, patch)
2012-08-17 00:33 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Taiju Tsuiki
Comment 1 2012-08-14 00:36:18 PDT
Created attachment 158245 [details] Patch
Vsevolod Vlasov
Comment 2 2012-08-16 01:10:26 PDT
Comment on attachment 158245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158245&action=review > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:782 > + ASSERT(m_frontendProvider->frontend()); Nit: consider extracting the following code if (!m_enabled || !m_frontendProvider) { *error = "FileSystem agent is not enabled"; return; } ASSERT(m_frontendProvider->frontend()); So that each protocol command started with if (!assertFrontend(error)) return; This way it should be shorter.
Taiju Tsuiki
Comment 3 2012-08-17 00:33:31 PDT
Created attachment 159027 [details] Patch
Taiju Tsuiki
Comment 4 2012-08-17 00:34:50 PDT
Comment on attachment 158245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158245&action=review >> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:782 >> + ASSERT(m_frontendProvider->frontend()); > > Nit: consider extracting the following code > > if (!m_enabled || !m_frontendProvider) { > *error = "FileSystem agent is not enabled"; > return; > } > ASSERT(m_frontendProvider->frontend()); > > So that each protocol command started with > > if (!assertFrontend(error)) > return; > > This way it should be shorter. Looks nice. Done.
WebKit Review Bot
Comment 5 2012-08-17 01:03:46 PDT
Comment on attachment 159027 [details] Patch Attachment 159027 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13514708
Peter Beverloo (cr-android ews)
Comment 6 2012-08-17 01:09:12 PDT
Comment on attachment 159027 [details] Patch Attachment 159027 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13521286
Vsevolod Vlasov
Comment 7 2012-08-20 01:58:50 PDT
Comment on attachment 159027 [details] Patch Please fix "ReportErrorTask" building error.
Vsevolod Vlasov
Comment 8 2012-08-20 01:59:39 PDT
Comment on attachment 159027 [details] Patch Oh, I see you are adding it in another patch.
WebKit Review Bot
Comment 9 2012-08-22 00:50:16 PDT
Comment on attachment 159027 [details] Patch Clearing flags on attachment: 159027 Committed r126273: <http://trac.webkit.org/changeset/126273>
WebKit Review Bot
Comment 10 2012-08-22 00:50:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.