Bug 9189

Summary:

[S60] Reindeer does not send any User-agent HTTP header

Product:

WebKit

Reporter:

Franklin Davis <franklin.davis>

Component:

WebKit Misc.

Assignee:

Bradley Morrison <bradley.morrison>

Status:

CLOSED FIXED

Severity:

Normal

CC:

S60webkit

Priority:

Keywords:

PlatformOnly

Version:

312.x

Hardware:

S60 Emulator

OS:

S60 3rd edition

URL:

http://waplabdc.nokia-boston.com/browser/users/fdavis/xhtml/xhtmlheaderall.asp

Bug Depends on:

Bug Blocks:

9068

Attachments:

Description	Flags
Return static User agent string if __BROWSER_SDK	zalan: review-
Removed BrowserVersion.h include	zalan: review-
Correct patch this time :)	zalan: review-
Updated static UA string to 3.1	zalan: review-
bah!	zalan: review+
Value of KHttpUserAgentString depends on __BROWSER_SDK	Sachin.Padma: review+

Franklin Davis

Reported 2006-05-31 08:19:36 PDT

Reindeer browser should send a reasonable HTTP header to allow AJAX features and other proper content formatting by sites. Suggestion: Mozilla/5.0 (SymbianOS/9.1; U; [en]; Series60/3.0 Reindeer/2006-05-31) AppleWebKit/413 (KHTML, like Gecko) Safari/413 where Reindeer/xxxx is some unique version identifier, either the build date or some other version number.

Attachments
Return static User agent string if __BROWSER_SDK (3.87 KB, patch) 2006-10-05 16:17 PDT, Bradley Morrison	zalan: review-	Details Formatted Diff Diff
Removed BrowserVersion.h include (17.42 KB, patch) 2006-10-06 10:35 PDT, Bradley Morrison	zalan: review-	Details Formatted Diff Diff
Correct patch this time :) (3.44 KB, patch) 2006-10-09 07:44 PDT, Bradley Morrison	zalan: review-	Details Formatted Diff Diff
Updated static UA string to 3.1 (2.62 KB, patch) 2006-10-11 11:07 PDT, Bradley Morrison	zalan: review-	Details Formatted Diff Diff
bah! (2.62 KB, patch) 2006-10-11 14:36 PDT, Bradley Morrison	zalan: review+	Details Formatted Diff Diff
Value of KHttpUserAgentString depends on __BROWSER_SDK (1.31 KB, patch) 2006-10-13 14:14 PDT, Bradley Morrison	Sachin.Padma: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Krishna

Comment 1 2006-06-02 10:04:12 PDT

Reproducible on the S60 webkit, displays nothing. Not reproducible on the Safari TOT. Safari displays the following user-agent header: "Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en) AppleWebKit/420+ (KHTML, like Gecko) Safari/417.9.2" Added "PlatformOnly" to keywords field.

Franklin Davis

Comment 2 2006-10-02 11:48:15 PDT

Would also be good to send other HTTP headers compatible with full browser. See http://discussion.forum.nokia.com/forum/showthread.php?t=90610&highlight=HTTP+headers+browser I suggest we send the same headers as 3.1, but for User-Agent I suggest: Mozilla/5.0 (SymbianOS/9.2; U; Series60/3.1 NokiaReindeerEmulator/1.0; Profile/MIDP-2.0 Configuration/CLDC-1.1) AppleWebKit/413 (KHTML, like Gecko) Safari/413

Bradley Morrison

Comment 3 2006-10-03 08:15:02 PDT

Adding S60 prefix to synopsis

Bradley Morrison

Comment 4 2006-10-03 08:15:14 PDT

Adding S60 prefix to synopsis

Bradley Morrison

Comment 5 2006-10-05 16:17:09 PDT

Created attachment 10936 [details] Return static User agent string if __BROWSER_SDK Please note I have updated to hardcoded UserAgentString to mention *Reindeer*, so this means if the UserAgentString is found in the central repository this value will be returned even if __BROWSER_SDK is not specified. Not sure if this is a problem but the patch can be updated if so.

Bradley Morrison

Comment 6 2006-10-05 16:18:24 PDT

Comment on attachment 10936 [details] Return static User agent string if __BROWSER_SDK Please also see previous comment about updated value of KHttpUserAgentString. I put *@nokia.com instead of *gmail.com in the review request

Bradley Morrison

Comment 7 2006-10-05 16:19:49 PDT

(In reply to comment #5) > Please note I have updated to hardcoded UserAgentString to mention *Reindeer*, > so this means if the UserAgentString is found in the central repository this > value will be returned even if __BROWSER_SDK is not specified. s/if the UserAgentString is found in the central repository/if the UserAgentString is NOT found in the central repository/ It's late, I'm going home. ;-)

alan

Comment 8 2006-10-06 07:04:46 PDT

Comment on attachment 10936 [details] Return static User agent string if __BROWSER_SDK 1. please use #if _browser_sdk in webkitcontrol.cpp to separate sdk and rdn functionality. 2. do we really need to include browserversion.h?

Bradley Morrison

Comment 9 2006-10-06 10:35:33 PDT

Created attachment 10948 [details] Removed BrowserVersion.h include

Bradley Morrison

Comment 10 2006-10-06 10:39:26 PDT

(In reply to comment #8) > (From update of attachment 10936 [details] [edit]) > 1. please use #if _browser_sdk in webkitcontrol.cpp to separate sdk and rdn > functionality. You mean: - // come up with a hardcoded UA string - iUserAgent = KHttpUserAgentString().AllocL(); + // return hardcoded string + iUserAgent = HBufC::NewL( KHttpUserAgentString().Length() ); + iUserAgent->Des().Copy( KHttpUserAgentString ); ? Since KHttpUserAgentString is now always 8 bits, this needs to happen regardless of whether __BROWSER_SDK is set. > 2. do we really need to include browserversion.h? Ahh, nope, removed and patch updated.

alan

Comment 11 2006-10-06 18:18:42 PDT

Comment on attachment 10948 [details] Removed BrowserVersion.h include wrong patch file. (the patch is about webuilogger)

Bradley Morrison

Comment 12 2006-10-09 07:44:33 PDT

Created attachment 10993 [details] Correct patch this time :) Correct patch this time :) I will probably send this to spadma for a 2nd opinion as he is available now.

alan

Comment 13 2006-10-10 15:03:15 PDT

Comment on attachment 10993 [details] Correct patch this time :) go back to 3.0 ua string. sending yet another (and very much different) is confusing.

Bradley Morrison

Comment 14 2006-10-11 11:07:52 PDT

Created attachment 11033 [details] Updated static UA string to 3.1 Also reworked patch a little so that static uastring not declared with _LIT8. does a conversion via HBufC8 in CHttpTransaction::AddRequestHeadersL instead.

alan

Comment 15 2006-10-11 14:03:57 PDT

Comment on attachment 11033 [details] Updated static UA string to 3.1 push uastring to the cleanupstack by calling NewLC instead. (cleanupstack gets out of sync and crashes in this patch)

Bradley Morrison

Comment 16 2006-10-11 14:36:34 PDT

Created attachment 11039 [details] bah! Patch calls HBufC::NewLC not HBufC::NewL now. I have to admit, good catch. But anyway ..... arrrrrghhhh! :P

alan

Comment 17 2006-10-11 18:47:52 PDT

Comment on attachment 11039 [details] bah! what a great patch! r=me

alan

Comment 18 2006-10-11 18:49:07 PDT

r17001

Bradley Morrison

Comment 19 2006-10-13 14:10:58 PDT

Sachin would prefer that the UA string is not different if not found in the cenrep.

Bradley Morrison

Comment 20 2006-10-13 14:14:15 PDT

Created attachment 11080 [details] Value of KHttpUserAgentString depends on __BROWSER_SDK

Sachin Padma

Comment 21 2006-10-27 13:02:10 PDT

Comment on attachment 11080 [details] Value of KHttpUserAgentString depends on __BROWSER_SDK r=me

Bradley Morrison

Comment 22 2007-01-23 11:42:30 PST

The UA string is correct, I'm setting this to resolved.

Krishna

Comment 23 2007-01-25 18:50:45 PST

TSW ID: KPOY-6UMP8F

Krishna

Comment 24 2007-02-19 17:06:34 PST

Closed

Note You need to log in before you can comment on or make changes to this bug.