Bug 92122

Summary: [NRWT] Rename baseline_search_path() to default_baseline_search_path()
Product: WebKit Reporter: Kristóf Kosztyó <kkristof>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, webkit.review.bot
Priority: P2 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64491, 90555    
Attachments:
Description Flags
proposed refactoring dpranke: review+

Kristóf Kosztyó
Reported 2012-07-24 08:26:40 PDT
The Port's baseline_search_path() method doesn't return the finally search path because of the --additional-platform-directory change the final path. It will be better if we rename it and add a new method which return the final path.
Attachments
proposed refactoring (5.19 KB, patch)
2012-07-24 08:29 PDT, Kristóf Kosztyó 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kristóf Kosztyó
Comment 1 2012-07-24 08:29:18 PDT
Created attachment 154072 [details] proposed refactoring
Dirk Pranke
Comment 2 2012-07-24 11:08:28 PDT
Comment on attachment 154072 [details] proposed refactoring Agreed. Looks good to me. Thanks!
Kristóf Kosztyó
Comment 3 2012-07-25 07:00:51 PDT
Committed r123614: <http://trac.webkit.org/changeset/123614>
Note You need to log in before you can comment on or make changes to this bug.