Bug 92491
| Summary: | Style checker is not strict enough in detecting of primary header for a .cpp file | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | cdumez |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mikhail Pozdnyakov
Style checker is not strict enough in detecting of primary header for a .cpp file.
This causes following problem: if a .cpp file does not have primary header
but includes another header file having the name same as a substring of this
.cpp file name, the following message is issued:
" Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. "
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mikhail Pozdnyakov
Little example:
File ewk_view_loader_client.cpp does not have primary header.
Adding '#include "ewk_view.h" ' causes an error message
mentioned in previous comment because ewk_view.h is erroneously treated as
a primary header.