Bug 92575

Summary: run-perf-tests should generate a results page
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, haraken, kling, koivisto, morrita, ojan, slewis, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 77037    
Bug Blocks:    
Attachments:
Description Flags
Screenshot of current results.html
none
Patch
none
Sample results page
none
Use the same filename as the output JSON
none
Removed tabs eric: review+

Ryosuke Niwa
Reported 2012-07-28 00:59:13 PDT
Right now, run-perf-tests doesn't provide a results page to view results. Given that one of common workflow is to performance tests before and after applying a patch and comparing results, run-perf-tests should generate a results page, and ideally provide a way to compare results from different runs.
Attachments
Screenshot of current results.html (deleted)
2012-07-28 01:38 PDT, Ryosuke Niwa 		no flags
Details
Patch (58.92 KB, patch)
2012-07-28 01:56 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Sample results page (deleted)
2012-07-28 02:02 PDT, Ryosuke Niwa 		no flags
Details
Use the same filename as the output JSON (58.89 KB, patch)
2012-07-28 02:23 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Removed tabs (58.91 KB, patch)
2012-07-28 02:31 PDT, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-07-28 01:38:02 PDT
Created attachment 155120 [details] Screenshot of current results.html
Ryosuke Niwa
Comment 2 2012-07-28 01:56:53 PDT
Created attachment 155121 [details] Patch
Ryosuke Niwa
Comment 3 2012-07-28 02:02:06 PDT
Created attachment 155123 [details] Sample results page
Ryosuke Niwa
Comment 4 2012-07-28 02:23:11 PDT
Created attachment 155124 [details] Use the same filename as the output JSON
Ryosuke Niwa
Comment 5 2012-07-28 02:24:16 PDT
Dear reviewers: the patch is actually quite small. It's bloated by the flot and flot.fillbetween.
WebKit Review Bot
Comment 6 2012-07-28 02:25:43 PDT
Attachment 155124 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'PerformanceTests/ChangeLog', u'Performance..." exit_code: 1 Tools/ChangeLog:15: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:18: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:19: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 7 2012-07-28 02:31:44 PDT
Created attachment 155125 [details] Removed tabs
Ryosuke Niwa
Comment 8 2012-07-28 03:13:00 PDT
Note that a natural follow up patch to this will be giving a default JSON output path, and then have run-perf-tests open the results page at the end like run-webkit-tests does when there are failures.
Eric Seidel (no email)
Comment 9 2012-07-29 14:57:04 PDT
Comment on attachment 155125 [details] Removed tabs I mean, we could easily have a resources/ directory for the results template, instead of inlining the minimize script. But this is also OK for now. run-perf-tests could even inline the scripts into the HTML if that were necessary.
Ryosuke Niwa
Comment 10 2012-07-29 14:59:09 PDT
Thanks for the review. (In reply to comment #9) > (From update of attachment 155125 [details]) > I mean, we could easily have a resources/ directory for the results template, instead of inlining the minimize script. My intention is to use this infrastructure for perf. EWS so being able to upload to Bugzilla without having to zip is quite important. > But this is also OK for now. run-perf-tests could even inline the scripts into the HTML if that were necessary. Yes, that's what we're doing here. We inline all scripts and JSON into the results page.
Ryosuke Niwa
Comment 11 2012-07-29 15:03:42 PDT
Committed r123985: <http://trac.webkit.org/changeset/123985>
Note You need to log in before you can comment on or make changes to this bug.