Bug 93081

Summary: CUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebCore Misc.Assignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, gyuyoung.kim, kenneth, morrita, ojan, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 92749    
Attachments:
Description Flags
patch
webkit.review.bot: commit-queue-
patch v2
abarth: review+, webkit.review.bot: commit-queue-
to be landed none

Mikhail Pozdnyakov
Reported 2012-08-03 02:09:41 PDT
Currently we have a CUSTOM_SCHEME_HANDLER completely independent from REGISTER_PROTOCOL_HANDLER flag. This is bad for the following reasons: 1) Have ugly #if ENABLE(REGISTER_PROTOCOL_HANDLER) || ENABLE(CUSTOM_SCHEME_HANDLER) in many places 2) if CUSTOM_SCHEME_HANDLER and REGISTER_PROTOCOL_HANDLER is not set, the User has weird API which contains isProtocolHandlerRegistered and unregisterProtocolHandler but does not contain registerProtocolHandler.
Attachments
patch (15.83 KB, patch)
2012-08-03 02:47 PDT, Mikhail Pozdnyakov 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch v2 (16.10 KB, patch)
2012-08-03 04:02 PDT, Mikhail Pozdnyakov 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
to be landed (16.00 KB, patch)
2012-08-07 00:02 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-08-03 02:47:53 PDT
Created attachment 156302 [details] patch
WebKit Review Bot
Comment 2 2012-08-03 03:13:51 PDT
Comment on attachment 156302 [details] patch Attachment 156302 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13421756
Mikhail Pozdnyakov
Comment 3 2012-08-03 04:02:26 PDT
Created attachment 156316 [details] patch v2 Fix cr-linux bot failure.
Mikhail Pozdnyakov
Comment 4 2012-08-06 05:18:22 PDT
Could please anyone review it? Thanks
Adam Barth
Comment 5 2012-08-06 13:27:10 PDT
Comment on attachment 156316 [details] patch v2 Ok.
WebKit Review Bot
Comment 6 2012-08-06 13:31:06 PDT
Comment on attachment 156316 [details] patch v2 Rejecting attachment 156316 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rivate.h patching file Source/WebKit/efl/ewk/ewk_view.cpp Hunk #2 FAILED at 761. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13448278
Mikhail Pozdnyakov
Comment 7 2012-08-07 00:02:54 PDT
Created attachment 156882 [details] to be landed
WebKit Review Bot
Comment 8 2012-08-07 01:34:09 PDT
Comment on attachment 156882 [details] to be landed Clearing flags on attachment: 156882 Committed r124866: <http://trac.webkit.org/changeset/124866>
WebKit Review Bot
Comment 9 2012-08-07 01:34:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.