Bug 93103

Summary: [V8] Move V8Proxy methods that set DOM attributes/callbacks to V8Binding
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85330    
Attachments:
Description Flags
Patch
abarth: commit-queue-
patch for landing
webkit.review.bot: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-08-03 06:03:00 PDT
To remove V8Proxy, we can move V8Proxy methods that set DOM attributes/callbacks to V8Binding.
Attachments
Patch (10.64 KB, patch)
2012-08-03 06:15 PDT, Kentaro Hara 		abarth: commit-queue-
DetailsFormatted DiffDiff
patch for landing (10.72 KB, patch)
2012-08-05 07:11 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (10.50 KB, patch)
2012-08-05 10:08 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-03 06:15:00 PDT
Created attachment 156346 [details] Patch
Adam Barth
Comment 2 2012-08-03 09:49:26 PDT
Comment on attachment 156346 [details] Patch Can we put this code into it's own header? We don't want to make V8Bindings.h into the new V8Proxy all-sing, all-dance file.
Kentaro Hara
Comment 3 2012-08-03 09:53:50 PDT
(In reply to comment #2) > (From update of attachment 156346 [details]) > Can we put this code into it's own header? We don't want to make V8Bindings.h into the new V8Proxy all-sing, all-dance file. Sure. Let me commit it tomorrow.
Kentaro Hara
Comment 4 2012-08-05 07:11:54 PDT
Created attachment 156560 [details] patch for landing
Kentaro Hara
Comment 5 2012-08-05 07:16:12 PDT
(In reply to comment #2) > (From update of attachment 156346 [details]) > Can we put this code into it's own header? We don't want to make V8Bindings.h into the new V8Proxy all-sing, all-dance file. Let me land this patch first. I found that there are already a couple of methods in V8Binding that should be moved to the own header (e.g. configureTemplate()). I'll move all the methods at a breath in a follow-up patch.
WebKit Review Bot
Comment 6 2012-08-05 08:38:15 PDT
Comment on attachment 156560 [details] patch for landing Rejecting attachment 156560 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: og Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/V8Binding.cpp patching file Source/WebCore/bindings/v8/V8Binding.h patching file Source/WebCore/bindings/v8/V8Proxy.cpp Hunk #1 FAILED at 84. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8Proxy.cpp.rej patching file Source/WebCore/bindings/v8/V8Proxy.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13443144
Kentaro Hara
Comment 7 2012-08-05 10:08:48 PDT
Created attachment 156565 [details] patch for landing
WebKit Review Bot
Comment 8 2012-08-05 11:40:40 PDT
Comment on attachment 156565 [details] patch for landing Clearing flags on attachment: 156565 Committed r124718: <http://trac.webkit.org/changeset/124718>
Note You need to log in before you can comment on or make changes to this bug.