Bug 93318

Summary:

[V8] Rename V8Helpers to V8BindingHelpers

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, gyuyoung.kim, japhet, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

93095

Attachments:

Description	Flags
Patch	webkit.review.bot: commit-queue-
patch for landing	webkit.review.bot: commit-queue-
patch for landing	webkit.review.bot: commit-queue-
patch for landing	none

Kentaro Hara

Reported 2012-08-06 18:36:40 PDT

For naming consistency, a file including binding utility methods should be prefixed by "V8Binding". In a follow-up patch, I'll move methods from V8Binding to V8BindingHelpers.

Attachments
Patch (14.15 KB, patch) 2012-08-06 18:50 PDT, Kentaro Hara	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
patch for landing (14.24 KB, patch) 2012-08-07 17:18 PDT, Kentaro Hara	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
patch for landing (14.20 KB, patch) 2012-08-08 03:29 PDT, Kentaro Hara	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
patch for landing (14.25 KB, patch) 2012-08-08 03:45 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-08-06 18:50:11 PDT

Created attachment 156822 [details] Patch

Eric Seidel (no email)

Comment 2 2012-08-07 14:57:01 PDT

Comment on attachment 156822 [details] Patch rs=me.

WebKit Review Bot

Comment 3 2012-08-07 17:03:45 PDT

Comment on attachment 156822 [details] Patch Rejecting attachment 156822 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13459004

Kentaro Hara

Comment 4 2012-08-07 17:18:25 PDT

Created attachment 157051 [details] patch for landing

WebKit Review Bot

Comment 5 2012-08-07 21:08:40 PDT

Comment on attachment 157051 [details] patch for landing Rejecting attachment 157051 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 49>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13451646

Kentaro Hara

Comment 6 2012-08-08 03:29:43 PDT

Created attachment 157166 [details] patch for landing

WebKit Review Bot

Comment 7 2012-08-08 03:34:12 PDT

Comment on attachment 157166 [details] patch for landing Rejecting attachment 157166 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: le Source/WebCore/bindings/v8/V8BindingHelpers.cpp patching file Source/WebCore/bindings/v8/V8BindingHelpers.h patching file Source/WebCore/bindings/v8/V8Helpers.cpp rm 'Source/WebCore/bindings/v8/V8Helpers.cpp' patching file Source/WebCore/bindings/v8/V8Helpers.h rm 'Source/WebCore/bindings/v8/V8Helpers.h' patching file Source/WebCore/bindings/v8/V8NPObject.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13448929

Kentaro Hara

Comment 8 2012-08-08 03:45:59 PDT

Created attachment 157167 [details] patch for landing

WebKit Review Bot

Comment 9 2012-08-08 04:45:08 PDT

Comment on attachment 157167 [details] patch for landing Clearing flags on attachment: 157167 Committed r125020: <http://trac.webkit.org/changeset/125020>

Note You need to log in before you can comment on or make changes to this bug.