Bug 93333

Summary: [V8] Factor out V8BindingPerIsolateData from V8Binding to a separate file
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, gyuyoung.kim, japhet, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93095    
Attachments:
Description Flags
Patch
none
Patch
webkit.review.bot: commit-queue-
patch for landing
webkit.review.bot: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-08-06 21:16:17 PDT
We can move V8BindingPerIsolateData to V8BindingPerIsolateData.{h,cpp}. I'll rename V8BindingPerIsolateData to V8PerIsolateData in a follow-up patch.
Attachments
Patch (24.34 KB, patch)
2012-08-06 21:21 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (24.34 KB, patch)
2012-08-06 21:34 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (24.30 KB, patch)
2012-08-07 18:25 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (24.47 KB, patch)
2012-08-07 23:18 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-06 21:21:53 PDT
Created attachment 156856 [details] Patch
WebKit Review Bot
Comment 2 2012-08-06 21:30:52 PDT
Comment on attachment 156856 [details] Patch Attachment 156856 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13447709
Kentaro Hara
Comment 3 2012-08-06 21:34:36 PDT
Created attachment 156857 [details] Patch
Adam Barth
Comment 4 2012-08-07 17:04:14 PDT
Comment on attachment 156857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156857&action=review > Source/WebCore/bindings/v8/V8Binding.h:40 > +#include "V8BindingPerIsolateData.h" Should we just call this V8PerIsolateData ?
Kentaro Hara
Comment 5 2012-08-07 17:06:48 PDT
(In reply to comment #4) > > Source/WebCore/bindings/v8/V8Binding.h:40 > > +#include "V8BindingPerIsolateData.h" > > Should we just call this V8PerIsolateData ? Yes, I'll rename V8BindingPerIsolateData to V8PerIsolateData, and rename V8BindingPerContextData to V8PerContextData, in a follow-up patch.
WebKit Review Bot
Comment 6 2012-08-07 17:45:42 PDT
Comment on attachment 156857 [details] Patch Rejecting attachment 156857 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: #1 FAILED at 37. Hunk #2 succeeded at 68 (offset -68 lines). Hunk #3 succeeded at 82 (offset -68 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8Binding.h.rej patching file Source/WebCore/bindings/v8/V8BindingPerIsolateData.cpp patching file Source/WebCore/bindings/v8/V8BindingPerIsolateData.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13449637
Kentaro Hara
Comment 7 2012-08-07 18:25:21 PDT
Created attachment 157074 [details] patch for landing
WebKit Review Bot
Comment 8 2012-08-07 22:16:29 PDT
Comment on attachment 157074 [details] patch for landing Rejecting attachment 157074 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n "['Tools/Scripts/build-webkit', '--debug', '--chromium', '--update-chromium']" exit_code: 2 get/webcore_dom/Source/WebCore/dom/MessagePort.o] Error 1 make: *** Waiting for unfinished jobs.... make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/ActiveDOMObject.o] Error 1 make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/Modules/filesystem/WorkerContextFileSystem.o] Error 1 make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/ScriptExecutionContext.o] Error 1 Full output: http://queues.webkit.org/results/13459085
Adam Barth
Comment 9 2012-08-07 22:46:46 PDT
Sorry for all the naming nits. The patches themselves are great, which makes my mind wander to how to improve the code further.
Kentaro Hara
Comment 10 2012-08-07 23:18:21 PDT
Created attachment 157127 [details] patch for landing
WebKit Review Bot
Comment 11 2012-08-08 03:21:02 PDT
Comment on attachment 157127 [details] patch for landing Clearing flags on attachment: 157127 Committed r125015: <http://trac.webkit.org/changeset/125015>
Note You need to log in before you can comment on or make changes to this bug.