Bug 93655

Summary:

Vertical writing mode can overflow fixed size grandparent container

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

Layout and Rendering

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, d-r, eric, esprehn, fmalita, gyuyoung.kim, hyatt, jchaffraix, johnme, mitz, ojan.autocc, pdr, rakuco, schenney, tabatkins, tony, vcarbune, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

96031

Bug Blocks:

96557

Attachments:

Description	Flags
original testcase	none
reduction	none
Patch	none
Patch	none
Patch	none
Patch	none
Update to ToT	none
Patch	none

Ojan Vafai

Reported 2012-08-09 14:20:00 PDT

Moving over test-cases from bug 87679 to focus on the writing-mode bug since that bug had two separate bugs (a flexbox bug and a writing-mode bug).

Attachments
original testcase (2.44 KB, text/html) 2012-08-09 14:21 PDT, Ojan Vafai	no flags	Details
reduction (858 bytes, text/html) 2012-08-09 14:21 PDT, Ojan Vafai	no flags	Details
Patch (21.28 KB, patch) 2012-09-07 15:55 PDT, Ojan Vafai	no flags	Details Formatted Diff Diff
Patch (219.01 KB, patch) 2012-09-13 13:46 PDT, Ojan Vafai	no flags	Details Formatted Diff Diff
Patch (221.86 KB, patch) 2012-09-13 16:11 PDT, Ojan Vafai	no flags	Details Formatted Diff Diff
Patch (221.67 KB, patch) 2012-09-14 15:15 PDT, Ojan Vafai	no flags	Details Formatted Diff Diff
Update to ToT (223.49 KB, patch) 2012-10-09 10:43 PDT, Ojan Vafai	no flags	Details Formatted Diff Diff
Patch (226.49 KB, patch) 2013-01-04 11:03 PST, Ojan Vafai	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Ojan Vafai

Comment 1 2012-08-09 14:21:18 PDT

Created attachment 157545 [details] original testcase

Ojan Vafai

Comment 2 2012-08-09 14:21:32 PDT

Created attachment 157546 [details] reduction

Ojan Vafai

Comment 3 2012-08-09 14:56:48 PDT

As best I can tell, this is the correct behavior per the old spec: http://dev.w3.org/csswg/css3-writing-modes/#orthogonal-auto. But the definition of fill-available in the height direction has changed in the new spec to walk up the tree until it finds a containing block with a definite height: http://dev.w3.org/csswg/css3-sizing/#extrinsic-sizing.

Elliott Sprehn

Comment 4 2012-08-09 15:01:18 PDT

(In reply to comment #3) > As best I can tell, this is the correct behavior per the old spec: http://dev.w3.org/csswg/css3-writing-modes/#orthogonal-auto. > > But the definition of fill-available in the height direction has changed in the new spec to walk up the tree until it finds a containing block with a definite height: http://dev.w3.org/csswg/css3-sizing/#extrinsic-sizing. There's no fill-available in your test case though?

Ojan Vafai

Comment 5 2012-08-09 15:12:54 PDT

(In reply to comment #4) > There's no fill-available in your test case though? The writing-mode spec link defines the auto-sized height for an orthogonal writing-mode in terms of the fill-available height.

Ojan Vafai

Comment 6 2012-09-07 15:55:15 PDT

Created attachment 162893 [details] Patch

Ojan Vafai

Comment 7 2012-09-13 13:46:59 PDT

Created attachment 163956 [details] Patch

Ojan Vafai

Comment 8 2012-09-13 16:11:00 PDT

Created attachment 163993 [details] Patch

WebKit Review Bot

Comment 9 2012-09-14 00:49:19 PDT

Comment on attachment 163993 [details] Patch Attachment 163993 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13839844 New failing tests: fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html

Ojan Vafai

Comment 10 2012-09-14 15:15:49 PDT

Created attachment 164234 [details] Patch

Dave Hyatt

Comment 11 2012-10-01 13:40:45 PDT

Comment on attachment 164234 [details] Patch The table border models test case looks like a regression. "Header One" is not fitting on one line.

Ojan Vafai

Comment 12 2012-10-01 13:52:41 PDT

(In reply to comment #11) > (From update of attachment 164234 [details]) > The table border models test case looks like a regression. "Header One" is not fitting on one line. I'm pretty sure this is correct. If you load it at tip of tree and force the height of the vertical-rl div to 586px, then you get the same wrapping behavior. This patch causes the difference because we now subtract the body's margin when computing the availableHeight.

Ojan Vafai

Comment 13 2012-10-09 10:43:37 PDT

Created attachment 167780 [details] Update to ToT

Ojan Vafai

Comment 14 2012-10-19 13:16:17 PDT

Anyone mind taking a stab a reviewing this?

Ojan Vafai

Comment 15 2013-01-04 11:03:19 PST

Created attachment 181335 [details] Patch

Dave Hyatt

Comment 16 2013-01-04 11:28:28 PST

Comment on attachment 181335 [details] Patch r=me