Bug 94598

Summary:

[V8] Move reportUnsafeAccessTo() from V8Proxy to BindingSecurity

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

abarth, gustavo, japhet, philn, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

85330

Attachments:

Description	Flags
Patch	abarth: review-, webkit-ews: commit-queue-

Kentaro Hara

Reported 2012-08-21 07:19:23 PDT

To kill V8Proxy, we can move reportUnsafeAccessTo() from V8Proxy to BindingSecurity.

Attachments
Patch (9.81 KB, patch) 2012-08-21 07:25 PDT, Kentaro Hara	abarth: review- webkit-ews: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-08-21 07:25:09 PDT

Created attachment 159685 [details] Patch

Early Warning System Bot

Comment 2 2012-08-21 07:42:37 PDT

Comment on attachment 159685 [details] Patch Attachment 159685 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13543788

Build Bot

Comment 3 2012-08-21 07:48:24 PDT

Comment on attachment 159685 [details] Patch Attachment 159685 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13556093

Early Warning System Bot

Comment 4 2012-08-21 07:51:37 PDT

Comment on attachment 159685 [details] Patch Attachment 159685 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13545547

Gyuyoung Kim

Comment 5 2012-08-21 08:24:12 PDT

Comment on attachment 159685 [details] Patch Attachment 159685 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13550375

Adam Barth

Comment 6 2012-08-21 08:39:48 PDT

Comment on attachment 159685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159685&action=review This isn't quite right. BindingSecurity.cpp is part of the "generic bindings", which means it's shared by JavaScriptCore and V8. JavaScriptCore has a much better implementation of this function. I'd like to delete the V8 implementation and share the better JSC implementation. I'll try to get that done in the next day or two. > Source/WebCore/bindings/generic/BindingSecurity.cpp:86 > + Frame* source = firstFrame(BindingState::instance()); The proximate problem is that you can't use BindingState::instance() outside of V8 because in JavaScriptCore, BindingState is the ExecState and JavaScriptCore doesn't keep the ExecState in a static the same way that V8 does.

Kentaro Hara

Comment 7 2012-08-21 09:07:47 PDT

(In reply to comment #6) > This isn't quite right. BindingSecurity.cpp is part of the "generic bindings", which means it's shared by JavaScriptCore and V8. JavaScriptCore has a much better implementation of this function. I'd like to delete the V8 implementation and share the better JSC implementation. I'll try to get that done in the next day or two. Makes sense. Then let me wait for your fix. (I'm not in a hurry:) Marking INVALID.

Note You need to log in before you can comment on or make changes to this bug.