Bug 94710
| Summary: | [V8] Remove template of V8DOMConfiguration::configureAttribute() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> |
| Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | abarth |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 93095 | ||
Kentaro Hara
template<T> is not needed for V8DOMConfiguration::configureAttribute(). We can remove the template and de-inline the method. Given that SetAccessor() does a bunch of complicated stuff, de-inlining V8DOMConfiguration::configureAttribute() would make sense.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kentaro Hara
Sorry, I was confused. Please ignore this bug.
configureAttribute() can be called for both ObjectTemplate and Object, so it needs to be implemented by template<T>, where T is ObjectTemplate or Object.