Bug 94724

Summary: [BlackBerry] Extend LayerFilterRenderer in preparation for CSS Shaders
Product: WebKit Reporter: Joshua Netterfield <jnetterfield>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94728    
Attachments:
Description Flags
Patch
none
Patch none

Joshua Netterfield
Reported 2012-08-22 10:32:53 PDT
There are some features missing in LayerFilterRenderer that are needed to implement CSS Shaders for BB10.
Attachments
Patch (21.62 KB, patch)
2012-08-23 15:22 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (20.72 KB, patch)
2012-08-24 07:22 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Netterfield
Comment 1 2012-08-23 15:22:22 PDT
Created attachment 160262 [details] Patch
Arvid Nilsson
Comment 2 2012-08-24 07:01:37 PDT
Comment on attachment 160262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160262&action=review LGTM, but please remove copy/paste in favor of LayerRenderer::orthoMatrix() > Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:240 > +static void orthogonalProjectionMatrix(TransformationMatrix& matrix, float left, float right, float bottom, float top) This code is already available in LayerRenderer::orthoMatrix(), no need for copy/paste > Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.h:48 > + virtual void onCompletion() { } The "on" prefix is not typically used in WebKit, instead they use the will/did/should or other prefixes. In this case, maybe a better name that doesn't even need a prefix can be made. The name is nothing to R- for, but it is unusual for the WebKit codebase. Since the calling function is called cleanUp() maybe this could be called cleanUp() to, but I'm not sure. To me, it looks like the clean up performed is mostly related to restoring state, so maybe restoreState() or something along those lines would make sense.
Joshua Netterfield
Comment 3 2012-08-24 07:22:01 PDT
Created attachment 160419 [details] Patch
Arvid Nilsson
Comment 4 2012-08-24 07:40:07 PDT
Comment on attachment 160419 [details] Patch Looks great!
WebKit Review Bot
Comment 5 2012-08-24 08:12:32 PDT
Comment on attachment 160419 [details] Patch Clearing flags on attachment: 160419 Committed r126587: <http://trac.webkit.org/changeset/126587>
WebKit Review Bot
Comment 6 2012-08-24 08:12:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.