Bug 94735
| Summary: | Layout test fast/text/emphasis-overlap.html started failing differently after r126312 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> |
| Component: | Platform | Assignee: | Koji Ishii <kojii> |
| Status: | NEW | ||
| Severity: | Normal | CC: | kojii, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 83512 | ||
| Bug Blocks: | |||
Kenneth Russell
After http://trac.webkit.org/changeset/126312/ , fast/text/emphasis-overlap.html started failing with "image" rather than "image+text" differences on Chromium Linux. Here are the flakiness dashboard results:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Ftext%2Femphasis-overlap.html
To be honest I don't understand exactly what's going on there because it looks like there are still text differences for Webkit Linux and other bots. However, I'm suppressing this failure in LayoutTests/platform/chromium/TextExpectations for the moment.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kenneth Russell
Committed r126324: <http://trac.webkit.org/changeset/126324>
Koji Ishii
hmm...me neither. I re-reviewed the changeset, but I don't think any code touches Linux at all. Sorry for the trouble anyway.
Tony Chang
The reason is that LayoutTests/platform/chromium-win/fast/text/emphasis-overlap-expected.txt was added. Chromium Linux will use results in chromium-win if there are no results in chromium-linux (for may tests, the results are the same).
I think going from image+text to image is a progression, so this seems fine to me.