Bug 95781

Summary: [BlackBerry] Rename BlackBerry specific Texture class
Product: WebKit Reporter: Arvid Nilsson <anilsson>
Component: WebKit BlackBerryAssignee: Arvid Nilsson <anilsson>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, anilsson, anlo, commit-queue, gyuyoung.kim, mifenton, mvujovic, rakuco, rwlbuis, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 114276    
Attachments:
Description Flags
Patch
none
Patch none

Arvid Nilsson
Reported 2012-09-04 14:13:36 PDT
BlackBerry port has disabled the Texture related code in FECustomFilter which I think will prevent us from using custom filter in SVG. We should rename the WebCore/platform/graphics/blackberry/Texture.h Texture class to LayerTexture so we can use gpu/Texture.h with FECustomFilter.
Attachments
Patch (50.94 KB, patch)
2013-04-10 02:26 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Patch (50.73 KB, patch)
2013-04-10 04:01 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2013-04-10 01:12:44 PDT
FECustomFilter no longer uses gpu/Texture but instead has a Platform3DObject. However, I still think the rename makes sense to avoid file and class name conflicts in the future.
Arvid Nilsson
Comment 2 2013-04-10 01:33:27 PDT
No longer related to CSS Shaders.
Arvid Nilsson
Comment 3 2013-04-10 02:26:35 PDT
Created attachment 197228 [details] Patch
Arvid Nilsson
Comment 4 2013-04-10 02:27:10 PDT
This is a straight up rename, no functional changes.
Arvid Nilsson
Comment 5 2013-04-10 04:01:45 PDT
Created attachment 197241 [details] Patch This patch does not actually need to modify FECustomFilter.cpp after all (see comment above), so remove that bit from the Changelog
Rob Buis
Comment 6 2013-04-10 07:37:31 PDT
Comment on attachment 197241 [details] Patch LGTM.
WebKit Commit Bot
Comment 7 2013-04-10 12:54:58 PDT
Comment on attachment 197241 [details] Patch Clearing flags on attachment: 197241 Committed r148129: <http://trac.webkit.org/changeset/148129>
WebKit Commit Bot
Comment 8 2013-04-10 12:55:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.