Bug 96081

Summary: We should have a localized string of empty for date time field
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dmazzoni, donggwan.kim, fishd, jamesr, tkent, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96032    
Attachments:
Description Flags
Patch 1
none
Patch 2 none

yosin
Reported 2012-09-07 00:57:36 PDT
Screen reader reads "--" for hour field, but, screen reader may read "---------", 9 hyphen, for month field. We should have localized string for empty field, such as "blank", to avoid screen reader reads many of hyphens.
Attachments
Patch 1 (5.00 KB, patch)
2012-09-07 01:12 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (5.01 KB, patch)
2012-09-07 01:42 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-09-07 01:12:50 PDT
Created attachment 162699 [details] Patch 1
yosin
Comment 2 2012-09-07 01:13:27 PDT
Comment on attachment 162699 [details] Patch 1 Could you review this patch? Thanks in advance.
WebKit Review Bot
Comment 3 2012-09-07 01:34:36 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kent Tamura
Comment 4 2012-09-07 01:35:45 PDT
Comment on attachment 162699 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=162699&action=review > Source/WebCore/platform/LocalizedStrings.h:171 > + String AXEmptyFieldValueDescription(); Empty field of what? It's unclear. Maybe AXDateTimeFieldEmptyValueDescription()? Or will you use it for other purposes?
yosin
Comment 5 2012-09-07 01:42:20 PDT
Created attachment 162708 [details] Patch 2
yosin
Comment 6 2012-09-07 01:43:32 PDT
Comment on attachment 162708 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Rename string id to AXDateTimeFieldEmptyValueText
Kent Tamura
Comment 7 2012-09-07 01:44:26 PDT
Comment on attachment 162708 [details] Patch 2 ok
yosin
Comment 8 2012-09-07 01:45:36 PDT
Comment on attachment 162708 [details] Patch 2 Clearing flags on attachment: 162708 Committed r127843: <http://trac.webkit.org/changeset/127843>
yosin
Comment 9 2012-09-07 01:45:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.