Bug 96107

Summary: [Gtk] Enable Resource Timing
Product: WebKit Reporter: José Dapena Paz <jdapena>
Component: WebKitGTKAssignee: José Dapena Paz <jdapena>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bburg, bugs-noreply, mrobinson, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 61138    
Bug Blocks:    
Attachments:
Description Flags
Patch pnormand: review-

José Dapena Paz
Reported 2012-09-07 07:36:05 PDT
Add settings for enabling performance timeline and resource timing support in WebKit GTK+. It will be disabled by default, waiting for a sufficiently mature implementation.
Attachments
Patch (10.12 KB, patch)
2012-09-07 07:50 PDT, José Dapena Paz 		pnormand: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
José Dapena Paz
Comment 1 2012-09-07 07:50:46 PDT
Created attachment 162770 [details] Patch Patch adding settings for enabling resource timing and performance timeline
Martin Robinson
Comment 2 2012-09-07 08:47:50 PDT
Comment on attachment 162770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162770&action=review > configure.ac:981 > +# check whether to enable Performance Timeline support > +AC_MSG_CHECKING([whether to enable Performance Timeline support]) > +AC_ARG_ENABLE(performance_timeline, > + AC_HELP_STRING([--enable-performance-timeline], > + [enable support for Performance Timeline (experimental) [default=no]]), > + [],[enable_performance_timeline=$enable_unstable_features]) > +AC_MSG_RESULT([$enable_performance_timeline]) I don't think we add configuration options for features that aren't complete yet. Zan has the details.
Zan Dobersek
Comment 3 2012-09-07 09:33:46 PDT
Comment on attachment 162770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162770&action=review >> configure.ac:981 >> +AC_MSG_RESULT([$enable_performance_timeline]) > > I don't think we add configuration options for features that aren't complete yet. Zan has the details. Correct. Both these features don't introduce any dependencies so the configuration flags aren't required. Besides all the changes in configure.ac, this also removes the need for checking the Automake conditionals in Source/WebCore/GNUmakefile.am.
Philippe Normand
Comment 4 2013-04-12 12:21:28 PDT
Comment on attachment 162770 [details] Patch This one got bitrot :( At least the autotools part. Would need to be rebased so EWS can process it.
Blaze Burg
Comment 5 2017-07-24 13:33:10 PDT
*** This bug has been marked as a duplicate of bug 30685 ***
Note You need to log in before you can comment on or make changes to this bug.