Bug 96790

Summary:

[V8] Prevent workers from calling back into other worlds

Product:

WebKit

Reporter:

Dan Carney <dcarney>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, haraken, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Dan Carney

Reported 2012-09-14 08:25:23 PDT

Prevent workers from calling back into other worlds

Attachments
Patch (5.14 KB, patch) 2012-09-14 08:35 PDT, Dan Carney	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dan Carney

Comment 1 2012-09-14 08:35:53 PDT

Created attachment 164161 [details] Patch

Dan Carney

Comment 2 2012-09-14 08:36:35 PDT

trying to track down cause of this flake: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=close-code-and-reason.html

Adam Barth

Comment 3 2012-09-14 13:09:48 PDT

Comment on attachment 164161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164161&action=review > Source/WebCore/bindings/v8/WorldContextHandle.cpp:51 > + if (v8::Context::InContext()) { > + v8::Handle<v8::Context> context = v8::Context::GetCurrent(); > + if (!context.IsEmpty()) { This is somewhat redundant. You can skip the v8::Context::InContext() call and just test whether v8::Context::GetCurrent() returns an empty handle.

Dan Carney

Comment 4 2012-09-14 13:26:51 PDT

(In reply to comment #3) > (From update of attachment 164161 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164161&action=review > > > Source/WebCore/bindings/v8/WorldContextHandle.cpp:51 > > + if (v8::Context::InContext()) { > > + v8::Handle<v8::Context> context = v8::Context::GetCurrent(); > > + if (!context.IsEmpty()) { > > This is somewhat redundant. You can skip the v8::Context::InContext() call and just test whether v8::Context::GetCurrent() returns an empty handle. That's what I had at first, but v8 crashes on GetCurrent when not in context.

Adam Barth

Comment 5 2012-09-14 13:40:08 PDT

> That's what I had at first, but v8 crashes on GetCurrent when not in context. Really! I didn't know that.

WebKit Review Bot

Comment 6 2012-09-14 14:09:24 PDT

Comment on attachment 164161 [details] Patch Clearing flags on attachment: 164161 Committed r128651: <http://trac.webkit.org/changeset/128651>

WebKit Review Bot

Comment 7 2012-09-14 14:09:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.