Bug 97134

Summary: Add optional keywords 'luminance'/'alpha' for 'mask-image' property to CSSParser
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Dirk Schulze <krit>
Status: RESOLVED INVALID    
Severity: Normal CC: achicu, cmarcelo, donggwan.kim, eric, hyatt, kling, koivisto, macpherson, menard, simon.fraser, syoichi, tabatkins, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html#the-mask-image
Bug Depends on: 21502, 103021    
Bug Blocks: 95389    
Attachments:
Description Flags
Patch none

Dirk Schulze
Reported 2012-09-19 14:14:30 PDT
The CSS Masking specification adds the optional value <mask-type> to 'mask-image': <mask-image># with <mask-image> = [<image> | none] <mask-type>? <mask-type> = luminance | alpha This allows switching to a different masking operation per image. All masks are "transformed" to alpha masks, drawn over each other and used as one alpha mask. Luminance masks are used by a lot of designers because tools from Corel and Adobe (possibly Inkscape and Gimp as well) create these kind of masks. This bug report just addresses adding the keywords to the CSS parser. Since the keywords are optional and the fallback is alpha, this won't break existing content that relies on CSS masking today.
Attachments
Patch (43.65 KB, patch)
2012-11-19 09:36 PST, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2012-09-26 09:59:08 PDT
*** Bug 97695 has been marked as a duplicate of this bug. ***
Dirk Schulze
Comment 2 2012-11-19 09:04:21 PST
There was a discussion to change the syntax of the 'mask-image' property on www-style with the topic "Re: Ambiguities in fill:url() / stroke:url() syntax"[1]. The proposal says that the syntax should look like this: mask-image: [<mask-source> [alpha | luminance]? ] | [<mask-image> [alpha | luminance]?]# The problem is the definition of <mask-source> and <mask-image>. Both use <url>, but the meaning differs. While <mask-source> means that it references a <mask> element for masking, <mask-image> references an CSS image for masking. The outcome of the discussion is, that we differ on the syntax of the URL if we take image or <mask> referencing. If the URL has a fragment identifier, we will parse it as <mask-source> and the fragment identifier references a <mask> element. If it doesn't have a fragment identifier, it is a CSS image. Since we decide on the URL, we can't differ if the resource with a fragment is actually an SVG document with <mask> element. Means url(image.png#frag) would be assumed to be an SVG image with <mask> element. I will upload a patch to discuss this strategy shortly. Adding more CSS people who may want to be involved in the review and the decision. [1] http://lists.w3.org/Archives/Public/www-style/2012Oct/0766.html
Dirk Schulze
Comment 3 2012-11-19 09:36:47 PST
Created attachment 174997 [details] Patch
Anders Carlsson
Comment 4 2014-02-05 11:05:37 PST
Comment on attachment 174997 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Dirk Schulze
Comment 5 2014-03-04 06:17:16 PST
This is its own property now and already implemented.
Note You need to log in before you can comment on or make changes to this bug.