Bug 97696

Summary: [Chromium][Win] Remove ensureFontLoaded from PlatformSupport
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, fishd, haraken, jamesr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97723    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch
none
WIP Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-09-26 10:29:15 PDT
[Chromium][Win] Remove ensureFontLoaded from PlatformSupport
Attachments
Patch (4.52 KB, patch)
2012-09-26 10:29 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (16.32 KB, patch)
2012-11-19 10:38 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
WIP Patch (14.91 KB, patch)
2012-11-28 10:40 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (14.92 KB, patch)
2012-11-28 13:41 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-09-26 10:29:53 PDT
Created attachment 165828 [details] Patch
Adam Barth
Comment 2 2012-09-26 10:34:10 PDT
Comment on attachment 165828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165828&action=review > Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:44 > No need for this blank line.
WebKit Review Bot
Comment 3 2012-09-26 11:13:45 PDT
Comment on attachment 165828 [details] Patch Clearing flags on attachment: 165828 Committed r129673: <http://trac.webkit.org/changeset/129673>
WebKit Review Bot
Comment 4 2012-09-26 11:13:48 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2012-09-26 13:26:25 PDT
Re-opened since this is blocked by bug 97723
Mark Pilgrim (Google)
Comment 6 2012-11-19 10:38:07 PST
Created attachment 175004 [details] Patch
James Robinson
Comment 7 2012-11-19 12:50:32 PST
Comment on attachment 175004 [details] Patch What was the build breakage last time and how does this avoid it?
Mark Pilgrim (Google)
Comment 8 2012-11-19 12:55:16 PST
The previous patch missed all the calling references in WebCore/platform/chromium/. (Still not sure why that passed EWS, but anyway... this patch includes them.)
Adam Barth
Comment 9 2012-11-19 12:55:34 PST
Comment on attachment 175004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175004&action=review > Source/WebCore/platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:-64 > - if (PlatformSupport::ensureFontLoaded(m_platformData.hfont())) { I wonder if we should provide this helper function in WebCore somewhere rather than inlining it everywhere.
James Robinson
Comment 10 2012-11-19 12:58:41 PST
(In reply to comment #8) > The previous patch missed all the calling references in WebCore/platform/chromium/. (Still not sure why that passed EWS, but anyway... this patch includes them.) We don't have any EWS coverage for the chromium-win build.
Mark Pilgrim (Google)
Comment 11 2012-11-20 12:22:19 PST
Is this ready for an r+ or r-?
Adam Barth
Comment 12 2012-11-20 12:54:54 PST
Comment on attachment 175004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175004&action=review >> Source/WebCore/platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:-64 >> - if (PlatformSupport::ensureFontLoaded(m_platformData.hfont())) { > > I wonder if we should provide this helper function in WebCore somewhere rather than inlining it everywhere. IMHO, we should add this helper function. Otherwise, we're making all these call sites much more verbose.
Mark Pilgrim (Google)
Comment 13 2012-11-28 10:40:42 PST
Created attachment 176516 [details] WIP Patch
Mark Pilgrim (Google)
Comment 14 2012-11-28 13:41:50 PST
Created attachment 176564 [details] Patch
Mark Pilgrim (Google)
Comment 15 2012-11-28 13:42:20 PST
Comment on attachment 176564 [details] Patch Fixed a typo. Ready for review now.
Adam Barth
Comment 16 2012-11-28 14:03:35 PST
Comment on attachment 176564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176564&action=review > Source/WebCore/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:178 > - if (PlatformSupport::ensureFontLoaded(hfont())) { > + if (FontPlatformData::ensureFontLoaded(hfont())) { No need for the FontPlatformData:: prefix here. We're already inside FontPlatformData.
WebKit Review Bot
Comment 17 2012-11-28 14:36:25 PST
Comment on attachment 176564 [details] Patch Clearing flags on attachment: 176564 Committed r136057: <http://trac.webkit.org/changeset/136057>
WebKit Review Bot
Comment 18 2012-11-28 14:36:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.