Bug 97888

Summary: Add appearance tests for multiple fields month input UI
Product: WebKit Reporter: yosin
Component: Tools / TestsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97299    
Bug Blocks:    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3 none

yosin
Reported 2012-09-28 04:07:05 PDT
This is a part of multiple fields month input UI tests.
Attachments
Patch 1 (6.94 KB, patch)
2012-09-28 04:27 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (67.89 KB, patch)
2012-09-30 21:32 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (69.25 KB, patch)
2012-10-01 00:52 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-09-28 04:27:07 PDT
Created attachment 166205 [details] Patch 1
WebKit Review Bot
Comment 2 2012-09-28 04:31:06 PDT
Attachment 166205 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/chromium/TestExpectations:3598: Path does not exist. [test/expectations] [5] LayoutTests/platform/chromium/TestExpectations:3599: Path does not exist. [test/expectations] [5] LayoutTests/platform/chromium/TestExpectations:3600: Path does not exist. [test/expectations] [5] LayoutTests/platform/chromium/TestExpectations:3601: Path does not exist. [test/expectations] [5] LayoutTests/platform/efl/TestExpectations:1421: Path does not exist. [test/expectations] [5] LayoutTests/platform/mac/TestExpectations:812: Path does not exist. [test/expectations] [5] LayoutTests/platform/win/TestExpectations:1987: Path does not exist. [test/expectations] [5] LayoutTests/platform/qt/TestExpectations:2721: Path does not exist. [test/expectations] [5] Total errors found: 8 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
yosin
Comment 3 2012-09-30 18:37:33 PDT
Comment on attachment 166205 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 4 2012-09-30 20:53:54 PDT
Comment on attachment 166205 [details] Patch 1 The patch has no tests. Please check what you uploaded before asking review.
yosin
Comment 5 2012-09-30 21:32:57 PDT
Created attachment 166404 [details] Patch 2
Build Bot
Comment 6 2012-09-30 21:57:14 PDT
Comment on attachment 166404 [details] Patch 2 Attachment 166404 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14086658 New failing tests: http/tests/workers/terminate-during-sync-operation.html
yosin
Comment 7 2012-09-30 23:06:23 PDT
Comment on attachment 166404 [details] Patch 2 Could you review this patch? Thanks in advance. P.S. cr-linux passed for multiple fields month input UI tests. Although, unrelated tests are failed. = Changes since the last review = * Added tests which were missed in previous patch.
Kent Tamura
Comment 8 2012-10-01 00:44:08 PDT
Comment on attachment 166404 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=166404&action=review > LayoutTests/ChangeLog:34 > + * platform/efl/TestExpectations: Changed to disable tests for multiple fields month input UI. > + * platform/mac/TestExpectations: ditto > + * platform/qt/TestExpectations: ditto > + * platform/win/TestExpectations: ditto Need to update platform/gtk/TextExpectations and platform/chromium-android/TestExpectations too.
yosin
Comment 9 2012-10-01 00:52:01 PDT
Created attachment 166418 [details] Patch 3
yosin
Comment 10 2012-10-01 00:53:32 PDT
Comment on attachment 166418 [details] Patch 3 Could you review this change? Thanks in advance. = Changes since the last review = * Add test expectations for chromium-android and gtk
Kent Tamura
Comment 11 2012-10-01 00:56:17 PDT
Comment on attachment 166418 [details] Patch 3 ok
yosin
Comment 12 2012-10-01 00:58:44 PDT
Comment on attachment 166418 [details] Patch 3 Clearing flags on attachment: 166418 Committed r130010: <http://trac.webkit.org/changeset/130010>
yosin
Comment 13 2012-10-01 00:58:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.