Bug 97907

Summary: [Qt] QRawWebView tests are broken after r129545
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Tools / TestsAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, menard, noam, ossy, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70236    
Attachments:
Description Flags
Patch none

Balazs Kelemen
Reported 2012-09-28 06:36:07 PDT
The issue here was that we were setting the page loader client before initialized the page. This is not correct, the API expects that the page is initialized, i.e. we have a living page at the web process side. Without that most of the API calls will be implicitly ignored. This has been revealed by http://trac.webkit.org/changeset/129545 because it changed the initializing of the loader client so that it requires sending a message.
Attachments
Patch (3.29 KB, patch)
2012-09-28 06:46 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2012-09-28 06:46:56 PDT
Created attachment 166242 [details] Patch
Balazs Kelemen
Comment 2 2012-09-28 06:55:34 PDT
Comment on attachment 166242 [details] Patch Clearing flags on attachment: 166242 Committed r129890: <http://trac.webkit.org/changeset/129890>
Balazs Kelemen
Comment 3 2012-09-28 06:55:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.