Bug 98992

Summary: Introduce Localizer::isRTL, and use it in DateTimeChooserImpl
Product: WebKit Reporter: Kent Tamura <tkent>
Component: PlatformAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, mifenton, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99291    
Attachments:
Description Flags
WIP
none
Patch haraken: review+

Kent Tamura
Reported 2012-10-10 22:04:03 PDT
Introduce Localizer::isRTL, and use it in DateTimeChooserImpl
Attachments
WIP (11.98 KB, patch)
2012-10-10 22:11 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (12.75 KB, patch)
2012-10-11 00:15 PDT, Kent Tamura 		haraken: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-10-10 22:11:26 PDT
Created attachment 168143 [details] WIP
Kent Tamura
Comment 2 2012-10-11 00:15:20 PDT
Created attachment 168151 [details] Patch
Kentaro Hara
Comment 3 2012-10-11 00:22:28 PDT
Comment on attachment 168151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168151&action=review > Source/WebKit/chromium/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Nit: Remove this line.
Kent Tamura
Comment 4 2012-10-11 00:45:30 PDT
Committed r131021: <http://trac.webkit.org/changeset/131021>
Kent Tamura
Comment 5 2012-10-11 02:26:42 PDT
A follow-up change: https://trac.webkit.org/changeset/131030 We needed to initialize "UErrorCode status" with U_ZERO_ERROR.
Note You need to log in before you can comment on or make changes to this bug.