Bug 99308

Summary: MediaStream API: Add better RTCPeerConnectionHandler creation logic
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, eric, feature-media-reviews, hta, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch
abarth: review+, abarth: commit-queue-
Patch for landing
none
Patch for landing none

Tommy Widenflycht
Reported 2012-10-15 04:45:12 PDT
Make sure that if the RTCPeerConnectionHandler can't be fully initialized let the RTCPeerConnection constructor throw an exception.
Attachments
Patch (7.59 KB, patch)
2012-10-15 04:52 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (8.79 KB, patch)
2012-10-17 00:48 PDT, Tommy Widenflycht 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (8.77 KB, patch)
2012-10-18 02:07 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.74 KB, patch)
2012-10-18 02:10 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-10-15 04:52:26 PDT
Created attachment 168680 [details] Patch
Tommy Widenflycht
Comment 2 2012-10-17 00:48:47 PDT
Created attachment 169111 [details] Patch
Adam Barth
Comment 3 2012-10-17 08:53:43 PDT
Comment on attachment 169111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169111&action=review > Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:71 > + return adoptPtr<RTCPeerConnectionHandler>(0); You can just return nullptr (or at least PassOwnPtr<RTCPeerConnectionHandler>() if that doesn't work).
Tommy Widenflycht
Comment 4 2012-10-18 02:07:13 PDT
Created attachment 169370 [details] Patch for landing
Tommy Widenflycht
Comment 5 2012-10-18 02:10:44 PDT
Created attachment 169371 [details] Patch for landing
Tommy Widenflycht
Comment 6 2012-10-18 03:18:48 PDT
(In reply to comment #3) > (From update of attachment 169111 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169111&action=review > > > Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:71 > > + return adoptPtr<RTCPeerConnectionHandler>(0); > > You can just return nullptr (or at least PassOwnPtr<RTCPeerConnectionHandler>() if that doesn't work). Ahh, that's the reason the old return 0; doesn't work anymore. Nice.
WebKit Review Bot
Comment 7 2012-10-18 03:23:49 PDT
Comment on attachment 169371 [details] Patch for landing Clearing flags on attachment: 169371 Committed r131721: <http://trac.webkit.org/changeset/131721>
Note You need to log in before you can comment on or make changes to this bug.