Bug 9938

Summary: Fix viewBox issues in Hixie's test
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 6018    
Attachments:
Description Flags
First attempt
darin: review-
Now with testcase darin: review+

Rob Buis
Reported 2006-07-15 12:45:48 PDT
Fix viewBox issues in tests error/010.xml and error/011.xml of Hixie's svg tests, see bug 6018.
Attachments
First attempt (2.91 KB, patch)
2006-07-15 13:24 PDT, Rob Buis 		darin: review-
DetailsFormatted DiffDiff
Now with testcase (25.61 KB, patch)
2006-07-25 11:17 PDT, Rob Buis 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2006-07-15 13:24:07 PDT
Created attachment 9467 [details] First attempt This patch should fix the problem. Let me know if the bug requires testcases, like Hixie's 010 and 011 error tests. Cheers, Rob.
Rob Buis
Comment 2 2006-07-15 14:24:06 PDT
Test for new email address, ignore. (In reply to comment #1) > Created an attachment (id=9467) [edit] > First attempt > > This patch should fix the problem. Let me know if the bug requires testcases, > like > Hixie's 010 and 011 error tests. > Cheers, > > Rob. >
Darin Adler
Comment 3 2006-07-24 21:20:18 PDT
Comment on attachment 9467 [details] First attempt Code change looks OK. Ideally we'd do the work without converting the string to ASCII. But the patch doesn't include a test case or changes to existing test results. So review- just for that.
Rob Buis
Comment 4 2006-07-25 11:17:12 PDT
Created attachment 9681 [details] Now with testcase The new patch has the two testcases, taken literally from Hixie's tests but renamed. Also included are the .png, .checksum files, not sure whether they need to be part of this patch, but I'll need them for landing for sure :) Cheers, Rob.
Darin Adler
Comment 5 2006-07-26 13:58:16 PDT
Comment on attachment 9681 [details] Now with testcase r=me
Note You need to log in before you can comment on or make changes to this bug.