Bug 99451

Summary: [EFL][WK2] Add API unit tests for scaling
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 99902    
Bug Blocks: 90451    
Attachments:
Description Flags
Patch
none
Patch
gyuyoung.kim: commit-queue-
rebased patch
gyuyoung.kim: commit-queue-
rebased patch none

Jinwoo Song
Reported 2012-10-16 04:16:22 PDT
API unit tests for ewk_view_scale_set/get() should be added.
Attachments
Patch (1.97 KB, patch)
2012-10-18 09:09 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (2.00 KB, patch)
2012-10-19 08:23 PDT, Jinwoo Song 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
rebased patch (2.00 KB, patch)
2012-10-19 21:47 PDT, Jinwoo Song 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
rebased patch (2.00 KB, patch)
2012-10-19 22:15 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2012-10-18 09:09:10 PDT
Created attachment 169424 [details] Patch
Gyuyoung Kim
Comment 2 2012-10-18 09:18:55 PDT
Comment on attachment 169424 [details] Patch Attachment 169424 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14456097
Jinwoo Song
Comment 3 2012-10-19 08:23:53 PDT
Created attachment 169622 [details] Patch
Gyuyoung Kim
Comment 4 2012-10-19 08:27:44 PDT
Comment on attachment 169622 [details] Patch Attachment 169622 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14462469
Jinwoo Song
Comment 5 2012-10-19 08:40:44 PDT
Build is okay in my local pc, but failed in ews. Linking CXX executable ../../bin/test_ewk2_view CMakeFiles/test_ewk2_view.dir/UIProcess/API/efl/tests/test_ewk2_view.cpp.o: In function `EWK2UnitTestBase_ewk_view_scale_Test::TestBody()': test_ewk2_view.cpp:(.text+0xc227): undefined reference to `ewk_view_scale_set' test_ewk2_view.cpp:(.text+0xc456): undefined reference to `ewk_view_scale_set' test_ewk2_view.cpp:(.text+0xc792): undefined reference to `ewk_view_scale_set' collect2: ld returned 1 exit status
Jinwoo Song
Comment 6 2012-10-19 21:38:46 PDT
The build is failed because the ewk_view_scale_set() is not exported. I think it is a bug and will be handled in https://bugs.webkit.org/show_bug.cgi?id=99902.
Jinwoo Song
Comment 7 2012-10-19 21:47:43 PDT
Created attachment 169754 [details] rebased patch
Gyuyoung Kim
Comment 8 2012-10-19 21:51:02 PDT
Comment on attachment 169754 [details] rebased patch Attachment 169754 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14473241
Jinwoo Song
Comment 9 2012-10-19 22:15:06 PDT
Created attachment 169755 [details] rebased patch
WebKit Review Bot
Comment 10 2012-10-19 22:38:01 PDT
Comment on attachment 169755 [details] rebased patch Clearing flags on attachment: 169755 Committed r131978: <http://trac.webkit.org/changeset/131978>
WebKit Review Bot
Comment 11 2012-10-19 22:38:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.