Bug 99593

Summary: MediaStream API: Rename owner to client in MediaStreamDescriptor
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, hta, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
abarth: review+, webkit.review.bot: commit-queue-
Patch for landing none

Tommy Widenflycht
Reported 2012-10-17 06:49:20 PDT
As discussed in #99080 rename owner to client in MediaStreamDescriptor. It's confusing for a RefCounted object to have an "owner".
Attachments
Patch (9.09 KB, patch)
2012-10-17 07:25 PDT, Tommy Widenflycht 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (9.11 KB, patch)
2012-10-19 04:16 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-10-17 07:25:48 PDT
Created attachment 169180 [details] Patch
Adam Barth
Comment 2 2012-10-19 01:41:22 PDT
Comment on attachment 169180 [details] Patch Thanks!
WebKit Review Bot
Comment 3 2012-10-19 02:04:09 PDT
Comment on attachment 169180 [details] Patch Rejecting attachment 169180 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /ChangeLog Auto-merging Tools/ChangeLog CONFLICT (content): Merge conflict in Tools/ChangeLog Failed to merge in the changes. Patch failed at 0001 Unreviewed fix after r131868. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14461371
Tommy Widenflycht
Comment 4 2012-10-19 04:16:46 PDT
Created attachment 169597 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-10-19 04:19:26 PDT
Comment on attachment 169597 [details] Patch for landing Rejecting attachment 169597 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14460426
Tommy Widenflycht
Comment 6 2012-10-19 05:29:01 PDT
Weird, this patch doesn't modify LayoutTests/ChangeLog...
Adam Barth
Comment 7 2012-10-19 10:03:05 PDT
Comment on attachment 169597 [details] Patch for landing Sorry, that bug has been cropping up a lot lately.
WebKit Review Bot
Comment 8 2012-10-19 10:14:46 PDT
Comment on attachment 169597 [details] Patch for landing Clearing flags on attachment: 169597 Committed r131914: <http://trac.webkit.org/changeset/131914>
Note You need to log in before you can comment on or make changes to this bug.