Bug 99902

Summary: [WK2][EFL] Modify ewk_view_scale_set to public API
Product: WebKit Reporter: KyungTae Kim <ktf.kim>
Component: WebKit EFLAssignee: KyungTae Kim <ktf.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99451    
Attachments:
Description Flags
Patch
none
Patch none

KyungTae Kim
Reported 2012-10-19 19:59:11 PDT
The function ewk_view_scale_set need to be public API for a scale setting on external programs.
Attachments
Patch (1.37 KB, patch)
2012-10-19 20:01 PDT, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.37 KB, patch)
2012-10-19 21:28 PDT, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
KyungTae Kim
Comment 1 2012-10-19 20:01:55 PDT
Created attachment 169749 [details] Patch
Gyuyoung Kim
Comment 2 2012-10-19 21:18:31 PDT
Comment on attachment 169749 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169749&action=review I think it would be good if you add test case as well. > Source/WebKit2/ChangeLog:3 > + [WK2][EFL] Modify ewk_view_scale_set to public API set to -> set to. Remove unneeded a space.
KyungTae Kim
Comment 3 2012-10-19 21:28:47 PDT
Created attachment 169752 [details] Patch
Gyuyoung Kim
Comment 4 2012-10-19 21:31:46 PDT
(In reply to comment #2) > (From update of attachment 169749 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169749&action=review > > I think it would be good if you add test case as well. I set r- because this patch should be added with test case.
KyungTae Kim
Comment 5 2012-10-19 21:33:50 PDT
If the 'test case' means a unit test test case, it is on the other bug: https://bugs.webkit.org/show_bug.cgi?id=99451 This is for fixing error on the build bot for that and 99285. I uploaded without test case because a similar case was merged without test case before : ​https://bugs.webkit.org/show_bug.cgi?id=94589
WebKit Review Bot
Comment 6 2012-10-19 21:52:41 PDT
Comment on attachment 169752 [details] Patch Clearing flags on attachment: 169752 Committed r131976: <http://trac.webkit.org/changeset/131976>
WebKit Review Bot
Comment 7 2012-10-19 21:52:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.