Bug 250842 - [ews] Do not send stepStarted event to Github directly for non-default repository
Summary: [ews] Do not send stepStarted event to Github directly for non-default reposi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-19 08:36 PST by Aakash Jain
Modified: 2023-01-31 13:35 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2023-01-19 08:36:10 PST
This is follow-up to https://bugs.webkit.org/show_bug.cgi?id=244694 in which we stopped sending stepStarted event to Github directly. At that time, we excluded non-default repositories (e.g: security repo), since we didn't had EWS status-bubble support for non-default repos. Now that EWS status-bubbles are working for all the repo, we should stop sending these events.

This will also reduce little bit of load from ews buildbot server, as for every build-step on every build, few database calls are done and network requests are made for this.
Comment 1 Radar WebKit Bug Importer 2023-01-19 08:38:48 PST
<rdar://problem/104429615>
Comment 2 Aakash Jain 2023-01-19 08:41:12 PST
Pull request: https://github.com/WebKit/WebKit/pull/8834
Comment 3 EWS 2023-01-19 09:08:40 PST
Committed 259086@main (dd20c04f786c): <https://commits.webkit.org/259086@main>

Reviewed commits have been landed. Closing PR #8834 and removing active labels.