Bug 250851 - [GARDENING][ BigSur+ JSC ] stress/intl-enumeration.js (JSC-Tests) are constantly failing
Summary: [GARDENING][ BigSur+ JSC ] stress/intl-enumeration.js (JSC-Tests) are constan...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Jenner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-19 10:06 PST by Robert Jenner
Modified: 2023-01-24 09:58 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2023-01-19 10:06:05 PST
The following stress/intl-enumeration.js JSC-Tests are constantly failing on BigSur and Monterey Release:

stress/intl-enumeration.js.bytecode-cache
stress/intl-enumeration.js.default
stress/intl-enumeration.js.dfg-eager
stress/intl-enumeration.js.dfg-eager-no-cjit-validate
stress/intl-enumeration.js.eager-jettison-no-cjit
stress/intl-enumeration.js.ftl-eager
stress/intl-enumeration.js.ftl-eager-no-cjit
stress/intl-enumeration.js.ftl-eager-no-cjit-b3o1
stress/intl-enumeration.js.ftl-no-cjit-b3o0
stress/intl-enumeration.js.ftl-no-cjit-no-inline-validate
stress/intl-enumeration.js.ftl-no-cjit-no-put-stack-validate
stress/intl-enumeration.js.ftl-no-cjit-small-pool
stress/intl-enumeration.js.ftl-no-cjit-validate-sampling-profiler
stress/intl-enumeration.js.lockdown
stress/intl-enumeration.js.mini-mode
stress/intl-enumeration.js.no-cjit-collect-continuously
stress/intl-enumeration.js.no-cjit-validate-phases
stress/intl-enumeration.js.no-ftl
stress/intl-enumeration.js.no-llint

HISTORY:
https://results.webkit.org/?suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&suite=javascriptcore-tests&test=stress%2Fintl-enumeration.js.bytecode-cache&test=stress%2Fintl-enumeration.js.default&test=stress%2Fintl-enumeration.js.dfg-eager&test=stress%2Fintl-enumeration.js.dfg-eager-no-cjit-validate&test=stress%2Fintl-enumeration.js.eager-jettison-no-cjit&test=stress%2Fintl-enumeration.js.ftl-eager&test=stress%2Fintl-enumeration.js.ftl-eager-no-cjit&test=stress%2Fintl-enumeration.js.ftl-eager-no-cjit-b3o1&test=stress%2Fintl-enumeration.js.ftl-no-cjit-b3o0&test=stress%2Fintl-enumeration.js.ftl-no-cjit-no-inline-validate&test=stress%2Fintl-enumeration.js.ftl-no-cjit-no-put-stack-validate&test=stress%2Fintl-enumeration.js.ftl-no-cjit-small-pool&test=stress%2Fintl-enumeration.js.ftl-no-cjit-validate-sampling-profiler&test=stress%2Fintl-enumeration.js.lockdown&test=stress%2Fintl-enumeration.js.mini-mode&test=stress%2Fintl-enumeration.js.no-cjit-collect-continuously&test=stress%2Fintl-enumeration.js.no-cjit-validate-phases&test=stress%2Fintl-enumeration.js.no-ftl&test=stress%2Fintl-enumeration.js.no-llint


The history is pretty clear pointing to the the revert at 257697@Main that appears to have caused these tests to fail.
Comment 1 Radar WebKit Bug Importer 2023-01-19 10:07:12 PST
<rdar://problem/104432972>
Comment 2 EWS 2023-01-19 12:08:59 PST
Test gardening commit 259104@main (a155b7e276ea): <https://commits.webkit.org/259104@main>

Reviewed commits have been landed. Closing PR #8847 and removing active labels.
Comment 3 Robert Jenner 2023-01-20 13:29:16 PST
Pull request: https://github.com/WebKit/WebKit/pull/8893
Comment 4 Robert Jenner 2023-01-20 13:30:51 PST
(In reply to Robert Jenner from comment #3)
> Pull request: https://github.com/WebKit/WebKit/pull/8893

Since we figured out what broke this, and how it was broken I have submitted a change to this test above. My knowledge of JSC tests is limited at best. So my change may not fix it. But I just thought I would try. So let's see what EWS does with it.
Comment 5 EWS 2023-01-23 13:28:11 PST
Committed 259237@main (8b53ef6d2244): <https://commits.webkit.org/259237@main>

Reviewed commits have been landed. Closing PR #8893 and removing active labels.
Comment 6 Robert Jenner 2023-01-23 17:22:30 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/9006
Comment 7 EWS 2023-01-24 09:43:21 PST
Test gardening commit 259289@main (0214f5ed6d34): <https://commits.webkit.org/259289@main>

Reviewed commits have been landed. Closing PR #9051 and removing active labels.
Comment 8 Robert Jenner 2023-01-24 09:58:02 PST
(In reply to Robert Jenner from comment #6)
> Re-opening for pull request https://github.com/WebKit/WebKit/pull/9006

Unfortunately it appears that my attempted fix did not actually solve the issues with this test and the changes to the timezone database. So I have re-opened this bug and have skipped the test in: https://commits.webkit.org/259289@main