WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250884
Potential Reduce calls to LayoutUnit(int)
https://bugs.webkit.org/show_bug.cgi?id=250884
Summary
Potential Reduce calls to LayoutUnit(int)
Ahmad Saleem
Reported
2023-01-19 18:02:34 PST
Hi Team, While going through Blink's commit, I came across another potential performance optimization in reducing CPU load but it does not have test case to confirm so would like to get input. Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/e3d125383e6023dccb9f052237751f1c9a8098ec
WebKit Source -
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.h#382
&
https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/LayoutSize.h#67
Just wanted to raise it to get input. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2023-01-19 18:06:37 PST
It has also initial patch to reduce CPU further: Blink Commit -
https://src.chromium.org/viewvc/blink?view=revision&revision=158483
Webkit Source -
https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/LayoutPoint.h#40
&
https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/LayoutSize.h#52
____ Performance Test Case based on commit -
https://jsfiddle.net/gz0ansv7/show
alan
Comment 2
2023-01-19 19:01:08 PST
yeah, we should do this regardless of any potential perf improvement (but it's a nice addition)
EWS
Comment 3
2023-01-21 15:42:39 PST
Committed
259177@main
(42948cd0674a): <
https://commits.webkit.org/259177@main
> Reviewed commits have been landed. Closing PR #8872 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2023-01-21 15:43:18 PST
<
rdar://problem/104516718
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug