Bug 250941 - SpeculativeJIT should be a subclass of DFG::JITCompiler
Summary: SpeculativeJIT should be a subclass of DFG::JITCompiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-21 09:58 PST by Keith Miller
Modified: 2023-01-22 11:25 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2023-01-21 09:58:41 PST 
Right now SpeculativeJIT has an m_jit member that's used on each line we want to emit an instruction, which is a lot. We also have to qualify the names of each enum we want to use because those enums are declared a super class of JITCompiler. Subclassing would allow us to clean up both those issues.
Comment 1 Keith Miller 2023-01-21 10:08:21 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8922
Comment 2 EWS 2023-01-22 11:24:57 PST 
Committed 259193@main (356da64c3b23): <https://commits.webkit.org/259193@main>

Reviewed commits have been landed. Closing PR #8922 and removing active labels.